Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Report fixes #3154

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Status Report fixes #3154

merged 2 commits into from
Nov 28, 2022

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Nov 24, 2022

Description of the Change

Fixes 2 issues with the Status Report UI:

  • Restores missing anchor IDs to report sections.
  • Fixes an issue where the report would crash when the Query Body field of some failed queries would contain invalid JSON. A specific example is the Limit of total fields [100] has been exceeded error, which includes 2 separate JSON objects in the query body. In these cases if JSON parsing fails the raw value will be displayed. The only difference in the result is that the value will not be 'pretty-printed'.

Closes #3152

How to test the Change

  • Add the following code to the codebase: add_filter( 'ep_total_field_limit', function() { return 100; } );
  • Run a full sync (Delete all data and sync)
  • Load any admin page (except the Status Report)
  • Click on the link in the admin notice
  • The window should scroll to the Failed Queries section.
  • Try to open the section, the report should not crash to a blank screen.

Credits

Props @JakePT, @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT requested a review from felipeelia November 24, 2022 03:08
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia added this to the 4.4.0 milestone Nov 28, 2022
@felipeelia felipeelia merged commit ceb48c1 into develop Nov 28, 2022
@felipeelia felipeelia deleted the fix/3152 branch November 28, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Status Report last details
3 participants