Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Network alias creation failed #3139

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix: Network alias creation failed #3139

merged 1 commit into from
Nov 22, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where sync command throws a warning message while creating the network alias when one of the sites is deactivated in the network.

Closes #3134

How to test the Change

Enabled the ElasticPress on network
Mark any site as a Deactivate
Try to index the the content either from dashboard or cli

Changelog Entry

Fixed - Network alias creation failed warning when one of the sites is deactivated.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.4.0 milestone Nov 18, 2022
@felipeelia felipeelia merged commit b2df208 into develop Nov 22, 2022
@felipeelia felipeelia deleted the fix/3134 branch November 22, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Network alias creation failed for posts
2 participants