Fix: Clicking on the Facet Term redirect to Homepage #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felipeelia Do you know what release received this update? I can't find a mention of it in there. |
|
It was released in 4.4.0 @fclaussen. You can check that under the "Milestone" section on the right side of this screen: |
|
@felipeelia Oh! Thank you! I did not notice the milestone on the sidebar. Thanks! |
rebeccahum
added a commit
to Automattic/ElasticPress
that referenced
this pull request
Mar 22, 2023
rebeccahum
added a commit
to Automattic/ElasticPress
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes the issue when clicking on the Facet terms redirects to homepage when the search parameter value is empty. The issue was that the
sparameter was removed from the URL because of theemptycheck.Closes #3012
How to test the Change
Changelog Entry
Credits
Props @burhandodhy
Checklist: