-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publicly expose a method for opening Instant Results. #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
added
needs documentation
needs tests
module:instant-results
Issues related to the Instant Results functionality
labels
Sep 6, 2022
JakePT
changed the title
WIP: Open Instant Results with an action.
WIP: Publicly expose a method for opening Instant Results.
Oct 9, 2022
JakePT
changed the title
WIP: Publicly expose a method for opening Instant Results.
Publicly expose a method for opening Instant Results.
Oct 9, 2022
@JakePT It seems the e2e test is not passing (I've triggered it several times now.) Do you mind fixing it before we merge this one? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Publicly expose a method for opening Instant Results, allowing third parties to open Instant Results manually.
I originally implemented this as a custom action hook, but I anticipate some refactoring for #2978 and didn't want to commit to an API just yet. For now this just makes
openModal()
publicly available.Closes #2507
How to test the Change
Calling the following code to a theme or plugin should cause Instant Results to open when the button is clicked:
Changelog Entry
Added a method for developers to manually open Instant Results,
window.epInstantResults.openModal()
.Credits
Props @JakePT
Checklist: