Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for Comments Feature #2955

Merged
merged 6 commits into from
Sep 8, 2022
Merged

E2E tests for Comments Feature #2955

merged 6 commits into from
Sep 8, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

Add E2E tests for Comments Feature

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Add E2E tests for Comments Feature
@burhandodhy burhandodhy force-pushed the burhan/e2e-for-comments branch from 59f81e4 to 524e91c Compare August 22, 2022 07:57
@burhandodhy burhandodhy marked this pull request as ready for review August 22, 2022 14:12
@burhandodhy burhandodhy added this to the 4.3.0 milestone Aug 23, 2022
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burhandodhy I left some comments, feel free to reach out via slack if I missed something obvious here. We will need to test this feature with Protected Content enabled as well (those tests will likely live in the protected-content.spec.js file. Are you planning to tackle that in a separate PR?

tests/cypress/integration/features/comments.spec.js Outdated Show resolved Hide resolved
tests/cypress/integration/features/comments.spec.js Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Aug 24, 2022
@felipeelia felipeelia merged commit 9fbab64 into develop Sep 8, 2022
@felipeelia felipeelia deleted the burhan/e2e-for-comments branch September 8, 2022 17:07
@burhandodhy burhandodhy mentioned this pull request Sep 23, 2022
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants