Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow outside clicks when instant results modal is activated #2833

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Allow outside clicks when instant results modal is activated #2833

merged 3 commits into from
Jun 20, 2022

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Jun 8, 2022

Description of the Change

This PR will allow the outside clicks when Instant results popup modal is activated

Closes #2788

Alternate Designs

Possible Drawbacks

Verification Process

  • Activate the instant results feature
  • Search for anything and notice that the popup will not allow the external clicks
  • After the change, outside buttons like admin bar are clickable

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed: Admin menu bar items are not clickable when instant results popup modal is activated

Credits

Props @MARQAS

@MARQAS MARQAS added this to the 4.2.1 milestone Jun 8, 2022
@MARQAS MARQAS requested a review from JakePT June 8, 2022 09:33
@MARQAS MARQAS requested a review from JakePT June 10, 2022 13:09
@MARQAS MARQAS assigned felipeelia and unassigned JakePT Jun 14, 2022
@felipeelia felipeelia removed their assignment Jun 14, 2022
@felipeelia felipeelia merged commit 8808b81 into develop Jun 20, 2022
@felipeelia felipeelia deleted the fix/issue-2788 branch June 20, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakePT JakePT JakePT approved these changes

Assignees

@MARQAS MARQAS

Labels
None yet
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

BUG: Admin menu bar items are not clickable.
3 participants
@MARQAS @JakePT @felipeelia