Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete search template from ElasticPress.io when deactivating Instant Results #2821

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Delete search template from ElasticPress.io when deactivating Instant Results #2821

merged 4 commits into from
Aug 10, 2022

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Jun 2, 2022 •
edited
Loading

Description of the Change

Deletes the search template from the ElasticPress.io API when Instant Results is deactivated.

Also fixes the syntax of the @hook inline docs for Instant Results.

Closes #2794

Verification Process

WIP

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - The public search API is automatically deactivated when the Instant Results feature is deactivated.

Credits

Props @JakePT

@JakePT
Copy link
Contributor Author

JakePT commented Jun 2, 2022

Note the endpoint is on the API is a WIP. Also, this might be something we want to do when the plugin itself is uninstalled.

@JakePT JakePT self-assigned this Jun 2, 2022
@JakePT JakePT added the wip label Jun 2, 2022
@JakePT JakePT added this to the 4.3.0 milestone Jun 2, 2022
@JakePT JakePT marked this pull request as ready for review August 9, 2022 12:28
@JakePT JakePT requested a review from felipeelia August 9, 2022 12:28
@JakePT JakePT assigned felipeelia and unassigned JakePT Aug 9, 2022
@JakePT JakePT added module:instant-results Issues related to the Instant Results functionality and removed wip labels Aug 9, 2022
@felipeelia felipeelia merged commit 2a70dbf into develop Aug 10, 2022
@felipeelia felipeelia deleted the feature/2794 branch August 10, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia Awaiting requested review from felipeelia

Assignees

@felipeelia felipeelia

Labels
module:instant-results Issues related to the Instant Results functionality
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Disabling Instant Results should deactivate search API
2 participants
@JakePT @felipeelia