Facet block #2722
Merged
Facet block #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
reviewed
May 3, 2022
JakePT
previously approved these changes
May 10, 2022
There was a problem hiding this comment.
@felipeelia LGTM. By the looks of it I think it just needs an ignore/disabled for the linting rule on the dangerouslySetInnerHtml line, and to be up to date with develop.
|
@JakePT I've pushed a new commit improving the preview a bit. Do you mind giving it a quick look? Thanks! |
JakePT
reviewed
May 11, 2022
There was a problem hiding this comment.
@felipeelia I wonder if the message in the preview could explain a little bit more about why the preview isn't available? Something like:
No categories found for available results.
Just a thought. Otherwise looks good.
JakePT
previously approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a block version of the Facet widget.
Closes #2689
Changelog Entry
Added: Facet block (previously only available as a widget.)
Credits
Props @felipeelia