Add generate_mapping to Post and Comment Indexable #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
changed the title
|
@rebeccahum I guess if we are aiming to make that a pattern across all Indexables, we should change the parent Indexable class, perhaps with a check to keep backward compatibility. What do you think? |
|
@felipeelia Let me know if this is what you had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The User and Term Indexable classes have the
generate_mapping()function:ElasticPress/includes/classes/Indexable/User/User.php
Line 753 in 9a04a23
ElasticPress/includes/classes/Indexable/Term/Term.php
Line 587 in 424ba22
It would be nice if the Post and Comment Indexable could have that same function, so we can piggyback onto it with some code via
$indexable->generate_mapping().Alternate Designs
N/A.
Possible Drawbacks
N/A.
Checklist:
Changelog Entry
Added - generate_mapping() to post and comment indexable
Credits
Props @rebasaurus