Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node packages update #2631

Merged
merged 8 commits into from
Mar 7, 2022
Merged

Node packages update #2631

merged 8 commits into from
Mar 7, 2022

Conversation

felipeelia
Copy link
Member

Mainly updating 10up-toolkit and adjusting things around it

Changelog Entry

Security - Node packages update

Credits

Props @felipeelia

mainly updating 10up-toolkit and adjusting things around it
@felipeelia felipeelia added this to the 4.0.0 milestone Mar 3, 2022
@felipeelia felipeelia self-assigned this Mar 3, 2022
@JakePT
Copy link
Contributor

JakePT commented Mar 4, 2022

@felipeelia It looks like the drag and drop sorting of Custom Results no longer works (although it's not actually throwing an error). I notice that it's using the react-beautiful-dnd library. This has been the cause of a couple of sites not being able to update to 5.9 as it's not compatible with React 17.x which is used by WordPress 5.9. So I think updating the version of React here to 17.x might've broken it. We may need to downgrade the version used by these EP features to 16. This raises an issue with #2613 that will need to be solved before that can be done.

Everything else seemed to work ok though, and I agree with the change you made to the strict value rule, at least while we're dealing with lots of relatively old CSS. Maybe after a refactor or redesign we could revisit the rule.

Copy link
Contributor

@JakePT JakePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine now.

@JakePT JakePT merged commit 2751322 into develop Mar 7, 2022
@JakePT JakePT deleted the chore/npm-updates branch March 7, 2022 03:04
@felipeelia felipeelia mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants