Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WooCommerce Orders search #2554

Merged
merged 22 commits into from
Jan 27, 2022
Merged

Fix WooCommerce Orders search #2554

merged 22 commits into from
Jan 27, 2022

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Jan 14, 2022

Description of the Change

Currently, if the user searches by a number that is an Order ID and also part of another order address:

  • Using ElasticPress will only return the order with the matching ID
  • Not using ElasticPress, both orders will be returned

This PR addresses that problem and also removes the call to WooCommerce function that tries to find orders using direct SQL queries.

Benefits

Both orders returned + one less call to MySQL.

Changelog Entry

Fixed: WooCommerce Orders Search.

@felipeelia felipeelia added this to the 4.0.0 (beta 2) milestone Jan 14, 2022
@felipeelia felipeelia self-assigned this Jan 14, 2022
@felipeelia felipeelia changed the base branch from develop to 4.x.x January 14, 2022 18:18
@felipeelia felipeelia changed the base branch from 4.x.x to develop January 26, 2022 14:27
@felipeelia felipeelia changed the base branch from develop to 4.x.x January 26, 2022 14:27
@felipeelia felipeelia merged commit cbd96aa into 4.x.x Jan 27, 2022
@felipeelia felipeelia deleted the fix/woocommerce-order-search branch January 27, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants