Instant Results feature #2481
Merged
Instant Results feature #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
commented
Dec 2, 2021
| * @param {number} props.total Total number of items. | ||
| * @return {WPElement} Element. | ||
| */ | ||
| export default ({ offset, onNext, onPrevious, perPage, total }) => { |
There was a problem hiding this comment.
@felipeelia On ES7 the total prop here might not be a number, it might be an object.
* Move availability check to requirements_status * New actions, filters, and checks
felipeelia
reviewed
Dec 2, 2021
Comment on lines
+2
to
+3
| import jQuery from 'jquery'; | ||
|
|
There was a problem hiding this comment.
@JakePT Currently we use WP's jQuery version (and the final goal would be to get rid of it entirely). Any reason why we simply don't define this as global instead of importing it?
There was a problem hiding this comment.
@felipeelia This is the only way I've been able to get jquery in the asset dependencies. Do you know the proper way to define jQuery as a global so that it's picked up?
| 'facets' => $this->get_facets_for_frontend(), | ||
| 'highlightTag' => 'mark', | ||
| 'isWooCommerce' => $this->is_woocommerce, | ||
| 'matchType' => 'all', |
There was a problem hiding this comment.
Didn't we already have a field for this, @JakePT?
…s into feature/instant-results
Just to add `mergeRules` to cssnano config to have sync.css working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
WIP
Alternate Designs
WIP
Benefits
WIP
Possible Drawbacks
WIP
Verification Process
WIP
Checklist:
Applicable Issues
WIP
Changelog Entry
WIP