Removing duplicate call to delete post #2314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When a post is deleted in ElasticPress, we see that two queries are sent to Elasticsearch to delete that post. Since they are duplicated, at least one of those queries always fails. This happens because we are sending the ep_delete_post signal twice.
This PR gets rid of that duplication.
Verification Process
We have this change deployed and running in production at VIP and it has drastically reduced the errors derived from calling the deletion of a post twice.
Checklist:
Changelog Entry