-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility function for checking if a request should be integrated. #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@felipeelia @brandwaffle This has been updated with a new @ since version and the feature is passed as a "context" parameter that can be used in filters. I'd still like a second pair of eyes to test thoroughly. |
felipeelia
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updates all checks for ElasticPress and feature integration to use a utility function that properly and centrally accounts for admin and AJAX requests. Addresses #2148.
Benefits
Uses a single utility function for determining whether ElasticPress or features should be integrated for each request, ensuring consistency with whether integration is enabled for certain features.
Verification Process
Features should be active on queries under the following conditions:
Default behaviour:
When
ep_admin_wp_query_integration
istrue
:When
ep_ajax_wp_query_integration
istrue
:Or when both filters are
true
:Checklist:
Applicable Issues
#2148
Changelog Entry
WIP