Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post_mime_type argument #2222

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented May 31, 2021

Description of the Change

This change updates the plugin to handle post_mime_type argument when it has an array with a MIME type without the subtype i.e image instead of image/png.

Alternate Designs

Benefits

It's possible to search images when using the Gutenberg editor or Web Stories plugin.

Possible Drawbacks

Verification Process

  1. Enable document indexing
  2. Enable admin and AJAX via ep_admin_wp_query_integration and ep_ajax_wp_query_integration
  3. Edit a post with the block editor
  4. Add a new image block to bring up the media modal
  5. Use the search bar to search for an image
  6. See the image

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #1604 #2206

Changelog Entry

Fixed post_mime_type argument issue when it has an array with a MIME type without the subtype

@Rahmon Rahmon added this to the 3.6.0 milestone May 31, 2021
@Rahmon Rahmon requested a review from felipeelia May 31, 2021 20:19
@felipeelia felipeelia assigned Rahmon and unassigned felipeelia Jun 1, 2021
@Rahmon Rahmon assigned felipeelia and unassigned Rahmon Jun 2, 2021
@felipeelia felipeelia merged commit 2a9ef32 into develop Jun 7, 2021
@felipeelia felipeelia deleted the fix/post-mime-type-issue-1604 branch June 7, 2021 15:43
@felipeelia felipeelia mentioned this pull request Jun 14, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image block and post_mime_type
2 participants