Added bypass for insert / delete for machines #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscarssanchez do you mind giving a look at this? You've already worked in this part of the code, so probably you'll have some additional context to it. Thanks in advance! |
|
@oscarssanchez can you please give it another look? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "take over" of #1968, just to address some small things.
Description of the Change
Allows indexing / deletion while in cron / WP CLI.
Props @nickdaugherty
cc: @rinatkhaziev @pschoffer @netsuso @parkcityj
Alternate Designs
N/A
Benefits
Allows indexing / deletion while in cron / WP CLI.
Possible Drawbacks
Allows indexing / deletion while in cron / WP CLI.
Verification Process
We needed a way to do indexing / deletion while in cron / WP CLI. After this change, it worked.
Checklist:
Applicable Issues
Closes #1968 .
Changelog Entry
Added permission check bypass for indexing / deleting for cron and WP CLI. Props @nickdaugherty