Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to posts_by_query property #2158

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Apr 5, 2021

Description of the Change

This change removes the references to posts_by_query property. This property was used by two functions that were removed by the commit 6d71e6c39f5bab11df49580ddcb813fef02ff9fc

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #1762

Changelog Entry

@Rahmon Rahmon added the bug Something isn't working label Apr 5, 2021
@Rahmon Rahmon requested a review from brandwaffle April 5, 2021 18:12
@Rahmon Rahmon self-assigned this Apr 5, 2021
Co-authored-by: felipeelia <felipe.elia@gmail.com>
@Rahmon Rahmon force-pushed the fix/remove-spl_object_hash-issue-1762 branch from 57eafd2 to 623a6d6 Compare April 5, 2021 18:17
@Rahmon Rahmon added this to the 3.5.7 milestone Apr 5, 2021
@felipeelia felipeelia modified the milestones: 3.5.7, 3.6.0 Apr 9, 2021
@brandwaffle brandwaffle merged commit 1e0c684 into develop Apr 16, 2021
@brandwaffle brandwaffle deleted the fix/remove-spl_object_hash-issue-1762 branch April 16, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using spl_object_hash() for storing found posts
4 participants