Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to change the ordering of the features on the Features page #1987

Merged
merged 9 commits into from
May 28, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Nov 26, 2020

Description of the Change

This PR adds two properties to the abstract class Feature that allow the developer to change the order of the features and chose if a feature should be on the left or right side when the features are listed on the Features page. Furthermore, changes are done in the dashboard-page.php to sort the array of features and to put on the left or right side.

Alternate Designs

Benefits

Change the order of the features to prioritize the most important, most used, or to show the features in a different way.

Possible Drawbacks

Verification Process

This has been tested manually just to validate the implementation.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #1983

Changelog Entry

Added custom sorting to features on the Feature page.

@felipeelia felipeelia added this to the 3.6.0 milestone Jan 22, 2021
includes/classes/Feature.php Outdated Show resolved Hide resolved
includes/partials/dashboard-page.php Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned Rahmon and unassigned felipeelia May 26, 2021
@Rahmon Rahmon assigned felipeelia and unassigned Rahmon May 26, 2021
@felipeelia felipeelia merged commit 5f76f26 into 10up:develop May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering of features
3 participants