Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Facet Widget & 3-level deep hierarchical taxonomy #1908

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Fix: Facet Widget & 3-level deep hierarchical taxonomy #1908

merged 1 commit into from
Oct 7, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Oct 7, 2020 •
edited
Loading

Description of the Change

This PR fixes #1810 by replace + with array_merge.

+ will combine items with same numeric keys but array_merge doesn't.

Alternate Designs

n/a

Benefits

Allows facet to work with 3 or more levels depth taxonomies.

Possible Drawbacks

None that I'm aware of.

Verification Process

See #1810.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #1810

Changelog Entry

@tlovett1 tlovett1 added this to the 3.5.0 milestone Oct 7, 2020
@tlovett1 tlovett1 merged commit 204d245 into develop Oct 7, 2020
@jeffpaul jeffpaul deleted the fix/1810 branch February 17, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dinhtungdu dinhtungdu

Labels
confirmed bug
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Facet Widget & 3-level deep hierarchical taxonomy
2 participants
@dinhtungdu @tlovett1