Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a separate sync page #1835

Merged
merged 63 commits into from
Nov 5, 2021
Merged

Add a separate sync page #1835

merged 63 commits into from
Nov 5, 2021

Conversation

helen
Copy link
Contributor

@helen helen commented Jul 14, 2020 •
edited
Loading

Description of the Change

Adds a separate sync screen that explains the different syncing options.

This is not yet complete - it needs to disable the syncing buttons while a sync is running and to actually trigger the appropriate sync from each button. I am not currently planning on handling this, so somebody else will need to take over this PR to complete it :)

Screen Shot 2020-07-14 at 4 55 05 PM

Alternate Designs

n/a

Benefits

Two separate sync paths, no more one-click access to a destructive syncing action without warning or explanation.

Possible Drawbacks

More clicks to sync again.

Verification Process

Clicked sync button in header.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Not sure if there is an issue or a PR for the actual non-destructive reindexing part.

Changelog Entry

Still needs

@felipeelia felipeelia self-assigned this Jul 14, 2020
@jeffpaul jeffpaul added this to the 3.6.0 milestone Dec 4, 2020
@mckdemps mckdemps modified the milestones: 3.6.0, Future Release Jan 29, 2021
@felipeelia felipeelia changed the base branch from develop to master April 19, 2021 16:23
@felipeelia felipeelia changed the base branch from master to develop April 19, 2021 16:23
This was referenced Apr 30, 2021
Closed
Closed
This was referenced Jun 3, 2021
Closed
Closed
@felipeelia felipeelia modified the milestones: 3.7.0, 4.0.0 Oct 12, 2021
@felipeelia felipeelia changed the base branch from develop to 3.7 October 13, 2021 13:37
@Rahmon Rahmon requested a review from felipeelia October 29, 2021 13:13
@Rahmon Rahmon assigned felipeelia and unassigned Rahmon Oct 29, 2021
@Rahmon Rahmon changed the title [WIP] Add a separate sync page Add a separate sync page Oct 29, 2021
felipeelia and others added 3 commits October 29, 2021 15:54
tott
tott approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@tott tott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me. we need to confirm which methods might be used for integrations and make sure people are not querying any transients or options directly and make sure the methods people use will still work.

includes/classes/Screen/Sync.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/Post.php Show resolved Hide resolved
@felipeelia felipeelia merged commit 926b2f8 into 4.x.x Nov 5, 2021
@felipeelia felipeelia deleted the add/sync-page branch November 5, 2021 18:40
@felipeelia felipeelia mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tott tott tott approved these changes

@felipeelia felipeelia Awaiting requested review from felipeelia

@oscarssanchez oscarssanchez Awaiting requested review from oscarssanchez

Assignees

@felipeelia felipeelia

Labels
high priority
Projects
None yet
Milestone
4.0.0 (beta 1)
Development

Successfully merging this pull request may close these issues.
6 participants
@helen @tott @felipeelia @jeffpaul @Rahmon @mckdemps