Add a Comments Indexable #1531
Merged
Add a Comments Indexable #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 15, 2019 14:24
… feature is activated.
…ry. Format results properly for the front-end.
… the search and parent params.
|
@brandwaffle @tlovett1 @tott please let me know once this gets through code review and if there are any changes needed from that review... thanks! |
@felipeelia thanks for the review 🙏 (1) I've fixed this issue and added some tests. (2) I've updated to better integrate with Protected Content enabled. However, I noticed that the Comments page does a lot of queries to retrieve the comments. |
6 tasks
|
@Rahmon assigning back to you to sort the last issue with WC orders and client notes as we've discussed. Thanks! |
felipeelia
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Similar to #1443, a new filter was added to WordPress core and is coming in 5.3 that allows comment queries to be short-circuited with your own results. This provides ElasticPress the ability to take over any queries that utilize
WP_Comment_Query.This PR adds a new Comments Indexable that will index all comments across a site (regardless of comment type or status) and then takes over
WP_Comment_Queryifep_integrateis true or if thesearchargument is used.Benefits
Comments will now be stored in elasticsearch and can be searched across as needed. Any queries that make use of
WP_Comment_Query, either directly or indirectly, can gain potential performance benefits by utilizing an elasticsearch query over a traditional database query.Possible Drawbacks
Not all queries will be made faster by this integration, so testing will need to be done to determine if it's worth using elasticsearch for comment queries in all situations.
Verification Process
Tested these changes locally on a multisite install, with 4 sites on the network. Each site had a handful of comments, some of these had replies, others did not.
WP_Comment_Query, withep_integrateset to true, runs the query against elasticsearchWP_Comment_Querysupports, to make sure those work when run against elasticsearchNote further testing is recommended here, to further ensure all the various query params work, especially when used in conjunction with each other.
Checklist: