Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert indexables to non-associative array #1232

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

oscarssanchez
Copy link
Contributor

@oscarssanchez oscarssanchez commented Feb 6, 2019

Hi @allan23 ,

Can you please review these changes that address #1231 ?

I found the localized post type/status variables were taken as an object instead of a array when plugin defaults is enabled. Also, I swapped post type for status and vice-versa when using plugin defaults, which was causing this to fail on safe values.

Thanks!

Change to correct post status/type
@oscarssanchez oscarssanchez requested a review from allan23 February 6, 2019 20:25
@allan23 allan23 merged commit f9d438f into 10up:develop Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants