Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use match_phrase as alternative for wildcard #1223

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Use match_phrase as alternative for wildcard #1223

merged 1 commit into from
Jan 30, 2019

Conversation

oscarssanchez
Copy link
Contributor

Hi @allan23 ,

This PR replaces the use of wildcard query for a match_phrase. This way, we account for queries that are not a pattern.

Thank you,

@oscarssanchez oscarssanchez requested a review from allan23 January 29, 2019 21:31
@jeffpaul
Copy link
Member

@oscarssanchez can you check the build failure before Allan dives into his review?

@allan23
Copy link
Contributor

allan23 commented Jan 30, 2019

@jeffpaul Travis is notorious with having issues. It's on our list to replace it with something that is consistent.

@allan23 allan23 merged commit 5819fcc into 10up:develop Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allan23 allan23 Awaiting requested review from allan23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarssanchez @jeffpaul @allan23