I already know how UnknownDeclaringType happen

It happen when the developer call `DynamicILInfo.GetTokenFor(RuntimeFieldHandle field)` rather than `DynamicILInfo.GetTokenFor(RuntimeFieldHandle field, RuntimeTypeHandle contextType)` to build DynamicMethod, .NET doesn't crash without declaring type, it can work fine also.
Especially, .NET2.0 doesn't support a public overload with RuntimeTypeHandle parameter, that's why so many protectors don't pass in this parameter.

As the reason is clear, such name/comment could be updated if necessary.

https://github.com/0xd4d/dnlib/blob/0b2dc951e3a74cd31e177fae62cc56dab676583e/src/DotNet/Emit/DynamicMethodBodyReader.cs#L16-L28
https://github.com/0xd4d/dnlib/blob/0b2dc951e3a74cd31e177fae62cc56dab676583e/src/DotNet/Emit/DynamicMethodBodyReader.cs#L458-L462
https://github.com/0xd4d/dnlib/blob/0b2dc951e3a74cd31e177fae62cc56dab676583e/src/DotNet/Emit/DynamicMethodBodyReader.cs#L458-L462

	public enum DynamicMethodBodyReaderOptions {
	/// <summary>
	/// No option is enabled
	/// </summary>
	None = 0,

	/// <summary>
	/// Some fields/methods have an unknown declaring type and don't have a context with
	/// that information. If this is enabled, the reader will try to guess it but it doesn't
	/// always work. If you get an <see cref="ArgumentException"/>, try enabling this option.
	/// </summary>
	UnknownDeclaringType = 0x00000001,
	}

	if ((options & DynamicMethodBodyReaderOptions.UnknownDeclaringType) != 0) {
	// Sometimes it's a generic type but obj != `GenericMethodInfo`, so pass in 'default' and the
	// runtime will try to figure out the declaring type. https://github.com/0xd4d/dnlib/issues/298
	return importer.Import(SR.MethodBase.GetMethodFromHandle((RuntimeMethodHandle)obj, default));
	}

	if ((options & DynamicMethodBodyReaderOptions.UnknownDeclaringType) != 0) {
	// Sometimes it's a generic type but obj != `GenericMethodInfo`, so pass in 'default' and the
	// runtime will try to figure out the declaring type. https://github.com/0xd4d/dnlib/issues/298
	return importer.Import(SR.MethodBase.GetMethodFromHandle((RuntimeMethodHandle)obj, default));
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I already know how UnknownDeclaringType happen #552

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development