Updated mitigation in section on arithmetic overflows #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The mitigation described in the section on arithmetic overflows is insufficient as it currently stands. Since
LessThan
only restricts the size of the difference|in[0] - in[1]|
between the two inputs, a malicious user try to withdrawp - 1
. As long as the current balance is non-negative this would satisfy the circuit, even thoughp - 1
is huge when viewed as an unsigned value.The correct mitigation is to use
LessThan
, together with constraints restricting the size of the inputs to ensure that they are non-negative. This can be done using theNum2Bits
template from Circomlib.Common Vulnerabilities Addition Checklist