Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.yaml didn't seem to contain some V lang keywords and was seemingly out-of-date. #3591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codemanticism
Copy link

@codemanticism codemanticism commented Dec 30, 2024

Closes #3590

@codemanticism
Copy link
Author

Why none of these project's maintainers have approved this?

@Andriamanitra
Copy link
Contributor

Why none of these project's maintainers have approved this?

Bear in mind that people working on micro are doing it in their free time, without payment, and they have other things going on in their life too. If you are waiting for something like a pull request review, or an answer to a question, be patient. It can take a while (think weeks or months, not hours...) for the maintainers to get to your pull request, especially when it's not a critical issue. Changes to the syntax files of niche languages are especially difficult to review because it requires some familiarity with the language in question.

Comment on lines -22 to -27
- symbol.attribute:
start: "^\\["
end: "\\]$"
rules:
- default: ".*"
- symbol: "\\b(deprecated|direct_array_access|if|inline|live|ref_only|typedef|windows_stdcall)\\b"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really not needed any longer?

Comment on lines -19 to -21
- identifier.class: "\\b([A-Z][A-Za-z0-9_]*)\\b"
- identifier.function: "\\b([a-z_]+\\()"
- symbol.operator: "\\b(i[ns])\\b|[-+/*<>!=~*%&:|,.?]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No class, function and operator support any longer?

runtime/syntax/v.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micro's V Lang color-coding could be improved.
3 participants