Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose: Fix Cmd + Return to send messages in preview mode on Mac. #32979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compose: Fix Cmd + Return to send messages in preview mode on Mac. #32979

wants to merge 1 commit into from

Conversation

Aditya8840
Copy link
Collaborator

@Aditya8840 Aditya8840 commented Jan 9, 2025 •
edited
Loading

Previously, Cmd + Return did not send messages in preview mode when configured by the user.

This commit fixes the logic to allow sending messages in preview mode with Cmd + Return as per user configuration.

Fixes: #32960

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@Aditya8840
compose: Fix Cmd + Return to send messages in preview mode on Mac.
3f07451 
Previously, Cmd + Return did not send messages in preview mode when
configured by the user.

This commit fixes the logic to allow sending messages in preview
mode with Cmd + Return as per user configuration.

Fixes: zulip#32960.
@alya
Copy link
Contributor

alya commented Jan 9, 2025

@amanagr could you please take a look? I haven't tested.

@alya alya added the maintainer review PR is ready for review by Zulip maintainers. label Jan 9, 2025
@amanagr
Copy link
Member

amanagr commented Jan 14, 2025

Code changes look good me. Didn't have my mac for testing this.

@amanagr amanagr added integration review Added by maintainers when a PR may be ready for integration. and removed maintainer review PR is ready for review by Zulip maintainers. labels Jan 14, 2025
nikhilae added a commit to nikhilae/zulip that referenced this pull request Jan 19, 2025
@nikhilae
Fix Cmd + Return to send messages in preview mode on Mac.zulip#32979
df24879
@nikhilae nikhilae mentioned this pull request Jan 19, 2025
Closed
12 tasks
@Aditya8840
Copy link
Collaborator Author

@timabbott This PR is currently awaiting your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amanagr amanagr

Labels
integration review Added by maintainers when a PR may be ready for integration. size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Mac, "Cmd" "Return" to send a message does not work in preview mode.
4 participants
@Aditya8840 @alya @amanagr @zulipbot