user_groups: Add markdown rendering for group descriptions. #32873

reharsh · 2025-01-02T12:28:35Z

This PR adds support for rendered descriptions for user groups.

Changes

Updated the NamedUserGroup model to include a rendered description.
Refactored backend functions to handle rendered descriptions for user groups.
Updated tests and documentation.
Added rendered descriptions to user group settings.
Group descriptions are saved and rendered on update.
Rendered descriptions are shown in places like:

Group list Item
Group Settings
Typeahead
Popovers
DM

The rendered description is also sent wherever the group's description is used.

Screenshots


User Group Settings
Direct Messages
Group List Item
Typeahead
Popover

Screen Recordings

Update/Edit user group

edit_recording.mov

Create user group with link in description

Screen.Recording.2024-12-29.at.8.24.41.PM.mov

Self-review checklist

Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

Explains differences from previous plans (e.g., issue description).
Highlights technical choices and bugs encountered.
Calls out remaining decisions and concerns.
Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

Each commit is a coherent idea.
Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

Visual appearance of the changes.
Responsiveness and internationalization.
Strings and tooltips.
End-to-end functionality of buttons, interactions and flows.
Corner cases, error conditions, and easily imagined bugs.

reharsh · 2025-01-02T12:59:53Z

Hey @alya , this PR is ready for review. Could you please take a look when you have a moment? Thanks!

alya · 2025-01-02T23:32:48Z

The screenshots look great! Please resolve the conflicts to prepare this for review.

reharsh · 2025-01-03T05:55:15Z

@alya done, please check!

alya · 2025-01-03T22:02:34Z

@sahil839 could you please take a look at this one? I haven't tested.

sahil839 · 2025-01-05T13:30:23Z

zerver/openapi/zulip.yaml

+            displaying this content so that emoji, LaTeX, and other syntax
+            work correctly. And any client-side security logic for
+            user-generated message content should be applied when displaying
+            this HTML as though it were the body of a Zulip message.


This and other changes in docs needs a "Changes" entry. Also, changelog.md and version.py should be updated accordingly.

sahil839 · 2025-01-05T13:37:16Z

zerver/lib/user_groups.py

    }

    full_members_group_info = {
        "name": SystemGroups.FULL_MEMBERS,
        "description": "Members of this organization, not including new accounts and guests",
+        "rendered_description": "<p>Members of this organization, not including new accounts and guests</p>",


Instead of doing this, can we just use render_group_description when creating the system groups?

I used render_group_description instead but, there was circular import issue, so I tried importing from zerver.actions.user_groups import render_group_description in function, it seems to work. can you please confirm if it is permitted?

zerver/views/user_groups.py

sahil839 · 2025-01-05T14:01:50Z

web/src/typeahead_helper.ts

    render_typeahead_item({
        primary: user_groups.get_display_group_name(user_group.name),
-        secondary: user_group.description,
+        // eslint-disable-next-line unicorn/prefer-string-replace-all
+        secondary_html: user_group.rendered_description.replace(/^<p>|<\/p>$/g, ""),


Why does this need replace but we do not do the same for streams?

reharsh · 2025-01-08T20:28:35Z

Hello @sahil839, I have made the changes, sorry I was busy for a few days. can you please take a look again, when you get time. thanks!

sahil839

Posted a couple of comments. Can do a complete review along with manual testing once you rebase the PR to resolve merge conflicts.

sahil839 · 2025-01-09T11:17:25Z

zerver/lib/user_groups.py

@@ -899,6 +902,13 @@ def create_system_user_groups_for_realm(realm: Realm) -> dict[str, NamedUserGrou
        everyone_on_internet_group_info,
    ]

+    from zerver.actions.user_groups import render_group_description


Can we just define render_group_description in this file itself, ie. zerver/lib/user_groups.py if that doesn't result in any import cycles?

from zerver.lib.markdown import markdown_convert ImportError: cannot import name 'markdown_convert' from partially initialized module 'zerver.lib.markdown' (most likely due to a circular import) (/srv/zulip/zerver/lib/markdown/__init__.py) from zerver.lib.mention import render_group_description ImportError: cannot import name 'render_group_description' from partially initialized module 'zerver.lib.mention' (most likely due to a circular import) (/srv/zulip/zerver/lib/mention.py) ERROR:root:Failed to forward GET /json/events to port 9993: Cannot connect to host 127.0.0.1:9993 ssl:default .... from zerver.lib.user_groups import ( ImportError: cannot import name 'get_group_setting_value_for_api' from partially initialized module 'zerver.lib.user_groups' (most likely due to a circular import) (/srv/zulip/zerver/lib/user_groups.py) .... from zerver.lib.user_groups import ( ImportError: cannot import name 'get_group_setting_value_for_api' from partially initialized module 'zerver.lib.user_groups' (most likely due to a circular import) #(/srv/zulip/zerver/lib/user_groups.py)

tried this! still encountering circular import error, also tried modifying other related files too, haven't got anywhere.
It'll be great if you can find time to check it out.

Ok, this seems fine for now then.

sahil839 · 2025-01-09T11:17:57Z

zerver/openapi/zulip.yaml

+                            rendered_description:
+                              type: string
+                              description: |
+                                The description of the user group rendered as HTML.


You would need to add **Changes** entry for all these added blocks.

reharsh · 2025-01-10T09:44:12Z

@sahil839 , made the changes, can you please take a look again. thanks!

sahil839 · 2025-01-10T13:57:34Z

zerver/openapi/zulip.yaml

+            user-generated message content should be applied when displaying
+            this HTML as though it were the body of a Zulip message.
+
+            **Changes**: Prior to Zulip 10.0 (feature level 338), markdown rendering


I think "New in Zulip 10.0 (feature level 338), for adding support for markdown rendering of group descriptions." would be a better phrasing.

sahil839 · 2025-01-10T14:16:58Z

zerver/actions/user_groups.py

@@ -278,9 +287,13 @@ def do_update_user_group_description(
        extra_data={
            RealmAuditLog.OLD_VALUE: old_value,
            RealmAuditLog.NEW_VALUE: description,
+            "property": "description",


Why is this needed? We already have a different event type for description.

oh.. right, removed!

sahil839 · 2025-01-10T14:19:58Z

zerver/tests/test_user_groups.py

@@ -2001,7 +2003,7 @@ def check_update_user_group(
        promote_new_full_members()
        check_update_user_group(
            "help",
-            "Troubleshooting team",
+            "Troubleshooting team\n",


Would be good to add a test for checking we don't embed url previews similar to the test we have for streams.

sahil839 · 2025-01-10T14:26:44Z

web/src/user_groups.ts

        group.description = event.data.description;
+        group.rendered_description = event.data.rendered_description;


I guess clean_up_group_description needs to be called here as well for the new value.

There is no need to update the event.data.rendered_description field here, doing group.rendered_description = clean_up_group_description(event.data.rendered_description) will be better.

sahil839 · 2025-01-10T14:33:37Z

web/src/user_group_edit.ts

+            rendered_description: postprocess_content(group.rendered_description),
+        });
+        $edit_container.find(".group-description-wrapper").html(html);
+        $group_row.find(".description").html(html);


Do we need to set the value rendered by render_user_group_description here? This is for the left panel of groups UI and I guess that is handled by browse_user_groups_list_item and it handles no description case using data-no-description attribute.

sahil839 · 2025-01-10T14:47:03Z

web/src/typeahead_helper.ts

    render_typeahead_item({
        primary: user_groups.get_display_group_name(user_group.name),
-        secondary: user_group.description,
+        secondary_html: user_group.rendered_description,


I can see that the description is not aligned correctly with the name in mention typeahead.

can you please repopulate your dev db, this is because earlier created groups don't have clean_up_descriptions

There exists groups in production as well, so we cannot do that here. I missed this before but existing groups should be handled using migrations.

sahil839 · 2025-01-10T14:51:10Z

zerver/lib/user_groups.py

@@ -899,6 +902,13 @@ def create_system_user_groups_for_realm(realm: Realm) -> dict[str, NamedUserGrou
        everyone_on_internet_group_info,
    ]

+    from zerver.actions.user_groups import render_group_description


Ok, this seems fine for now then.

reharsh · 2025-01-12T13:30:06Z

@sahil839 made the changes, PTAL.

reharsh · 2025-01-15T21:31:12Z

Hello, @sahil839! I've modified migration script, please take a look when you have time.

sahil839 · 2025-01-16T03:29:36Z

zerver/migrations/0649_namedusergroup_rendered_description.py

+    from zerver.actions.user_groups import render_group_description
+
+    NamedUserGroup = apps.get_model("zerver", "NamedUserGroup")
+    all_named_user_groups = NamedUserGroup.objects.exclude(description="")


I think batching might be needed here and probably updating the group objects in bulk as well like we do in migrations for setting defaults of group settings, for deploying this if there are large number of user groups having description.

Also, would be better to have this as a separate migration file for deployment ease.

sahil839 · 2025-01-16T03:58:10Z

web/src/user_groups.ts

@@ -76,6 +80,13 @@ export function remove(user_group: UserGroup): void {
    user_group_by_id_dict.delete(user_group.id);
 }

+export function clean_up_group_description(rendered_description: string): string {
+    if (rendered_description !== undefined) {


Can this be undefined because the type of rendered_description above is string.

sahil839 · 2025-01-16T04:01:24Z

web/src/user_groups.ts

        group.description = event.data.description;
+        group.rendered_description = event.data.rendered_description;


There is no need to update the event.data.rendered_description field here, doing group.rendered_description = clean_up_group_description(event.data.rendered_description) will be better.

sahil839 · 2025-01-16T04:03:38Z

web/src/user_group_edit.ts

@@ -469,7 +471,10 @@ export function handle_member_edit_event(group_id: number, user_ids: number[]):
 export function update_group_details(group: UserGroup): void {
    const $edit_container = get_edit_container(group);
    $edit_container.find(".group-name").text(user_groups.get_display_group_name(group.name));
-    $edit_container.find(".group-description").text(group.description);
+    const html = render_user_group_description({
+        rendered_description: postprocess_content(group.rendered_description),


I am not sure why we do postprocess_content only here when updating the description in right panel and not in other cases. I guess we do the same for streams as well, but we should check why is this required only here and not in other places.

looks like render_browse_user_group_list_item html somehow contains postprocessed content already, like with title,target etc. and postprocess_content here doesn't really make any difference.

Yes. Since we are passing the rendered template here, I guess this is not need since rendered_markdown helper used in templates handles this.

found it!
there is this handlebars helper in template.ts

Handlebars.registerHelper( "rendered_markdown", (content: string) => new Handlebars.SafeString(postprocess_content(content)), );

which already does postprocessing for rendered_desc everywhere (left_sidebar, right_sidebar, typeaheads, popovers), same for stream desc, so we don't really need this postprocess_content.

also trying to figure out migration bit, but no luck yet, can't understand why the same thing worked for 0206_stream_rendered_description.py:(

reharsh · 2025-01-16T16:31:37Z

Hii @sahil839, I've made the changes, but getting an error while trying to migrate with new migration script.

migration file

from django.db import migrations, transaction
from django.db.backends.base.schema import BaseDatabaseSchemaEditor
from django.db.migrations.state import StateApps
from django.db.models import F, Max, Min, OuterRef

def render_all_user_group_descriptions(
    apps: StateApps, schema_editor: BaseDatabaseSchemaEditor
) -> None:
    # FIXME: Application code should not be imported from migrations.
    from zerver.actions.user_groups import render_group_description

    NamedUserGroup = apps.get_model("zerver", "NamedUserGroup")
    BATCH_SIZE = 1000
    max_id = NamedUserGroup.objects.exclude(description="").aggregate(Max("id"))[
        "id__max"
    ]
    if max_id is None:
        # Do nothing if there are no user groups on the server.
        return
    
    lower_bound = NamedUserGroup.objects.exclude(description="").aggregate(Min("id"))[
        "id__min"
    ]

    while lower_bound <= max_id:
        upper_bound = lower_bound + BATCH_SIZE - 1
        print(f"Processing batch {lower_bound} to {upper_bound} for NamedUserGroup")

        with transaction.atomic():
            all_named_user_groups = NamedUserGroup.objects.exclude(
                id__gte=lower_bound, id__lt=upper_bound, description="")
            for user_group in all_named_user_groups:
                user_group.rendered_description = render_group_description(
                user_group.description, user_group.realm
                )
            NamedUserGroup.objects.bulk_update(all_named_user_groups, fields=["rendered_description"], batch_size=BATCH_SIZE)

        lower_bound += BATCH_SIZE


class Migration(migrations.Migration):

    dependencies = [
        ("zerver", "0649_namedusergroup_rendered_description"),
    ]

    operations = [
        migrations.RunPython(
            render_all_user_group_descriptions,
            reverse_code=migrations.RunPython.noop,
            elidable=True,
        ),
    ]

Traceback

(zulip-py3-venv) vagrant@4b23a8f20b01:/srv/zulip$ ./manage.py migrate
Operations to perform:
  Apply all migrations: analytics, auth, confirmation, contenttypes, corporate, otp_static, otp_totp, pgroonga, phonenumber, sessions, social_django, zerver, zilencer
Running migrations:
  Applying zerver.0650_set_namedusergroup_rendered_description...Processing batch 33 to 1032 for NamedUserGroup
Traceback (most recent call last):
  File "/srv/zulip/./manage.py", line 150, in <module>
    execute_from_command_line(sys.argv)
  File "/srv/zulip/./manage.py", line 115, in execute_from_command_line
    utility.execute()
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 413, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 459, in execute
    output = self.handle(*args, **options)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 107, in wrapper
    res = handle_func(*args, **kwargs)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/commands/migrate.py", line 356, in handle
    post_migrate_state = executor.migrate(
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/executor.py", line 135, in migrate
    state = self._migrate_all_forwards(
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/executor.py", line 167, in _migrate_all_forwards
    state = self.apply_migration(
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/executor.py", line 252, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/migration.py", line 132, in apply
    operation.database_forwards(
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/operations/special.py", line 193, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/srv/zulip/zerver/migrations/0650_set_namedusergroup_rendered_description.py", line 35, in render_all_user_group_descriptions
    user_group.rendered_description = render_group_description(
  File "/srv/zulip/zerver/actions/user_groups.py", line 174, in render_group_description
    return markdown_convert(text, message_realm=realm, no_previews=True).rendered_content
  File "/srv/zulip/zerver/lib/markdown/__init__.py", line 2824, in markdown_convert
    ret = do_convert(
  File "/srv/zulip/zerver/lib/markdown/__init__.py", line 2736, in do_convert
    realm_url=message_realm.url,
AttributeError: 'Realm' object has no attribute 'url'

these groups seem to have no host so I added:

realm_host = getattr(user_group.realm, 'host', None)
if not realm_host:
        print(f"Skipping user group {user_group.name}: realm host is missing")
        continue

output is...

Skipping user group role:nobody: realm host is missing Skipping user group role:owners: realm host is missing Skipping user group role:administrators: realm host is missing Skipping user group role:moderators: realm host is missing Skipping user group role:fullmembers: realm host is missing Skipping user group role:members: realm host is missing Skipping user group role:everyone: realm host is missing Skipping user group role:internet: realm host is missing Skipping user group role:nobody: realm host is missing Skipping user group role:owners: realm host is missing Skipping user group role:administrators: realm host is missing Skipping user group role:moderators: realm host is missing Skipping user group role:fullmembers: realm host is missing Skipping user group role:members: realm host is missing Skipping user group role:everyone: realm host is missing Skipping user group role:internet: realm host is missing Skipping user group hamletcharacters: realm host is missing Skipping user group role:nobody: realm host is missing Skipping user group role:owners: realm host is missing Skipping user group role:administrators: realm host is missing Skipping user group role:moderators: realm host is missing Skipping user group role:fullmembers: realm host is missing Skipping user group role:members: realm host is missing Skipping user group role:everyone: realm host is missing Skipping user group role:internet: realm host is missing Skipping user group new bolds: realm host is missing Skipping user group new italics: realm host is missing Skipping user group this is link: realm host is missing

If you have time can you please look into it.

sahil839

Posted a couple of comments.

Regarding migration, I tried running ./manage.py migrate with the migration file that you have in this PR without any changes and it gives the same error that you mentioned. I think it is because uri is a property on Realm and not a DB field, but am not sure.

sahil839 · 2025-01-17T07:31:24Z

web/src/user_group_edit.ts

@@ -469,7 +471,10 @@ export function handle_member_edit_event(group_id: number, user_ids: number[]):
 export function update_group_details(group: UserGroup): void {
    const $edit_container = get_edit_container(group);
    $edit_container.find(".group-name").text(user_groups.get_display_group_name(group.name));
-    $edit_container.find(".group-description").text(group.description);
+    const html = render_user_group_description({
+        rendered_description: postprocess_content(group.rendered_description),


Yes. Since we are passing the rendered template here, I guess this is not need since rendered_markdown helper used in templates handles this.

sahil839 · 2025-01-17T07:39:25Z

web/src/typeahead_helper.ts

+export let render_user_group = (user_group: {
+    name: string;
+    rendered_description: string;
+    description: string;


description is not used anymore.

This commit adds support for rendered descriptions for user groups. changes: 1. Updated the NamedUserGroup model to include a rendered description. 2. Refactored backend functions to handle rendered descriptions for user groups. 3. Updated tests and documentation. 4. Added rendered descriptions to user group settings. 5. Group descriptions are saved and rendered on update. 6. Rendered descriptions are shown in places like: - Group list - Group Settings - Typeahead - Popovers The rendered description is also sent wherever the group's description is used. Fixes: zulip#32559

reharsh · 2025-01-17T18:50:36Z

Thank you, @sahil839, for your time on this!

I just figured out that running all migrations together (./tools/provision --force) resolves the issue, likely due to a model state inconsistency with the custom RunPython code was causing it. It seems consistent with other files too, I think this is expected, given migrations are applied sequentially. Let me know if you have any other thoughts.
again thank you so much -- I've made the changes—please review them whenever you have time.

sahil839 · 2025-01-18T08:50:55Z

You can do provisioning and rebuild the DB in development environment, but that cannot be done in production. Same migration file for stream description works, so am not sure how to fix this.

reharsh · 2025-01-18T14:12:41Z

Ok... then I'll continue to look for a fix,
but while running stream_rendered_description by ./manage.py migrate zerver 0206_stream_rendered_description or any other old migrations it gives me following error. I can't run those too... like you said it works for you. any insights?

traceback

(zulip-py3-venv) vagrant@4b23a8f20b01:/srv/zulip$ ./manage.py migrate zerver 0206_stream_rendered_description
Operations to perform:
  Target specific migration: 0206_stream_rendered_description, from zerver
Traceback (most recent call last):
  File "/srv/zulip/./manage.py", line 150, in <module>
    execute_from_command_line(sys.argv)
  File "/srv/zulip/./manage.py", line 115, in execute_from_command_line
    utility.execute()
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 413, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 459, in execute
    output = self.handle(*args, **options)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/base.py", line 107, in wrapper
    res = handle_func(*args, **kwargs)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/core/management/commands/migrate.py", line 301, in handle
    pre_migrate_state = executor._create_project_state(with_applied_migrations=True)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/executor.py", line 91, in _create_project_state
    migration.mutate_state(state, preserve=False)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/migration.py", line 91, in mutate_state
    operation.state_forwards(self.app_label, new_state)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/operations/fields.py", line 165, in state_forwards
    state.remove_field(app_label, self.model_name_lower, self.name)
  File "/srv/zulip-venv-cache/14cbac6fefe6ac8472cebd0e64812b1d7d6157fc/zulip-py3-venv/lib/python3.10/site-packages/django/db/migrations/state.py", line 258, in remove_field
    old_field = model_state.fields.pop(name)
KeyError: 'create_public_stream_policy'

sahil839 · 2025-01-20T03:41:35Z

I meant I have not seen any previous discussion of any such failure when the stream rendered description work was done. The way you are trying to run the single migration run will expectedly not work because the Database structure has change a lot since that migration.

I think would be better to ask for suggestions on CZO if you cannot get a fix.

zulipbot · 2025-01-22T21:30:00Z

Heads up @reharsh, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot added size: XL area: settings (user groups) User groups related settings issues labels Jan 2, 2025

zulipbot added the has conflicts label Jan 3, 2025

reharsh force-pushed the issue-32559 branch from 9fdcb2c to 20ed7fe Compare January 3, 2025 04:36

zulipbot removed the has conflicts label Jan 3, 2025

reharsh force-pushed the issue-32559 branch from 20ed7fe to 7c24552 Compare January 3, 2025 05:27

alya assigned sahil839 Jan 3, 2025

alya added the maintainer review PR is ready for review by Zulip maintainers. label Jan 3, 2025

sahil839 reviewed Jan 5, 2025

View reviewed changes

reharsh force-pushed the issue-32559 branch 3 times, most recently from 9b21d22 to 74a0f01 Compare January 8, 2025 19:39

zulipbot added the has conflicts label Jan 9, 2025

sahil839 reviewed Jan 9, 2025

View reviewed changes

reharsh force-pushed the issue-32559 branch from 74a0f01 to 5e742b3 Compare January 10, 2025 09:21

zulipbot removed the has conflicts label Jan 10, 2025

sahil839 reviewed Jan 10, 2025

View reviewed changes

reharsh force-pushed the issue-32559 branch 2 times, most recently from af67481 to 5437bb3 Compare January 12, 2025 12:08

zulipbot added the has conflicts label Jan 13, 2025

reharsh force-pushed the issue-32559 branch from 5437bb3 to 41bbb0c Compare January 15, 2025 20:22

zulipbot removed the has conflicts label Jan 15, 2025

reharsh force-pushed the issue-32559 branch from 41bbb0c to 85649e9 Compare January 15, 2025 20:32

sahil839 reviewed Jan 16, 2025

View reviewed changes

zulipbot added the has conflicts label Jan 16, 2025

sahil839 reviewed Jan 17, 2025

View reviewed changes

reharsh force-pushed the issue-32559 branch from 85649e9 to b65ae5b Compare January 17, 2025 17:03

zulipbot removed the has conflicts label Jan 17, 2025

reharsh force-pushed the issue-32559 branch from b65ae5b to d7a96c5 Compare January 17, 2025 17:43

reharsh force-pushed the issue-32559 branch from d7a96c5 to c5dd806 Compare January 17, 2025 18:04

zulipbot added the has conflicts label Jan 22, 2025

		group.description = event.data.description;
		group.rendered_description = event.data.rendered_description;

user_groups: Add markdown rendering for group descriptions. #32873

Are you sure you want to change the base?

user_groups: Add markdown rendering for group descriptions. #32873

Conversation

reharsh commented Jan 2, 2025

Changes

Screenshots

reharsh commented Jan 2, 2025

alya commented Jan 2, 2025

reharsh commented Jan 3, 2025

alya commented Jan 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reharsh commented Jan 8, 2025

sahil839 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reharsh commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reharsh commented Jan 12, 2025

reharsh commented Jan 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reharsh commented Jan 16, 2025

sahil839 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reharsh commented Jan 17, 2025

sahil839 commented Jan 18, 2025

reharsh commented Jan 18, 2025

sahil839 commented Jan 20, 2025

zulipbot commented Jan 22, 2025