docs: Checking this change.

zulip · shuklamaneesh23 · Dec 28, 2024 · Dec 28, 2024 · Jan 6, 2025 · 78dc6b304b27f7fade23bc985e9ac74f3e4e9af2
commit 78dc6b304b27f7fade23bc985e9ac74f3e4e9af2
diff --git a/api/resend-email-invite b/api/resend-email-invite
diff --git a/api_docs/changelog.md b/api_docs/changelog.md
@@ -20,6 +20,12 @@ format used by the Zulip server that they are interacting with.
 
 ## Changes in Zulip 10.0
 
+**Feature level 333**
+
+* [`PATCH /users`](/api/update-user): Added `send_account_modification_notifications`
+  function in `do_change_full_name` which notify the user when an admin changes
+  their full name.
+
 **Feature level 332**
 
 * [`POST /register`](/api/register-queue): Added

diff --git a/help/configure-automated-notices.md b/help/configure-automated-notices.md
@@ -59,6 +59,15 @@ You will be notified if someone [subscribes you to a
 channel](/help/add-or-remove-users-from-a-channel#add-users-to-a-channel), or
 changes your [group](/help/user-groups) membership.
 
+
+## Notices about user account details changes
+
+{!admin-only.md!}
+
+When an administrator [modifies](/help/change-a-users-name) something about a user's account, it would notify
+them that a change was made. We have a Notification Bot that send a private message
+to the user informing them about the change.
+
 ### New user announcements
 
 {!admin-only.md!}

diff --git a/version.py b/version.py
@@ -34,7 +34,7 @@
 # new level means in api_docs/changelog.md, as well as "**Changes**"
 # entries in the endpoint's documentation in `zulip.yaml`.
 
-API_FEATURE_LEVEL = 332  # Last bumped for data deletion of deactivated realms.
+API_FEATURE_LEVEL = 333  # Last bumped for stream_ids and include_realm_default_subscriptions.
 
 # Bump the minor PROVISION_VERSION to indicate that folks should provision
 # only when going from an old version of the code to a newer version. Bump

diff --git a/zerver/actions/user_settings.py b/zerver/actions/user_settings.py
@@ -626,7 +626,7 @@ def send_account_modification_notifications(
 
     realm = user_profile.realm
     sender = get_system_bot(settings.NOTIFICATION_BOT, realm.id)
-    if acting_user:
+    if acting_user is not None:
         detailed_message = f"{silent_mention_syntax_for_user(acting_user)} has updated your `{property}`.\n\n- **Old `{property}`:** {old_value}\n- **New `{property}`:** {new_value}"
     else:
         detailed_message = f"The following updates have been made to your account.\n\n- **Old `{property}`:** {old_value}\n- **New `{property}`:** {new_value}"

diff --git a/zerver/tests/test_events.py b/zerver/tests/test_events.py
@@ -2142,15 +2142,15 @@ def test_change_avatar_fields(self) -> None:
 
     def test_change_full_name(self) -> None:
         now = timezone_now()
-        with self.verify_action(num_events=2) as events:
-            do_change_full_name(self.user_profile, "Sir Hamlet", self.example_user("iago"))
+        with self.verify_action() as events:
+            do_change_full_name(self.user_profile, "Sir Hamlet", self.user_profile)
         check_realm_user_update("events[0]", events[0], "full_name")
         self.assertEqual(
             RealmAuditLog.objects.filter(
                 realm=self.user_profile.realm,
                 event_type=AuditLogEventType.USER_FULL_NAME_CHANGED,
                 event_time__gte=now,
-                acting_user=self.example_user("iago"),
+                acting_user=self.user_profile,
             ).count(),
             1,
         )
@@ -2165,7 +2165,7 @@ def test_change_full_name(self) -> None:
                 event_time__gte=now,
                 acting_user=self.user_profile,
             ).count(),
-            0,
+            1,
         )
 
         self.set_up_db_for_testing_user_access()