streams: Send message when a user is unsubscribed from a channel. #32149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya8840
force-pushed
the
unsubscribe
branch
6 times, most recently
from
d0723af to
5b34d4d
Compare
Aditya8840
force-pushed
the
unsubscribe
branch
3 times, most recently
from
7c518dd to
930404c
Compare
Aditya8840
force-pushed
the
unsubscribe
branch
from
930404c to
6e060c2
Compare
|
@alya , This PR is ready for review !! |
|
@Aditya8840 #29307 already has some work on this with a lot of review feedbacks. Does this PR has work on top of that ? |
|
Sure, I'll rebase the commit. This PR also addresses the previously unaddressed feedback on #29307. I’d appreciate initial feedback on the implementation. |
This commit introduces a silent mention notification to be sent when a user is subscribed to a channel.
Previously, Notification Bot only sent messages to notify users when they were added to channels by others. However, there was no corresponding notification when they were removed from channels. This commit ensures that when a user is unsubscribed from a channel by another user, Notification Bot sends a message to inform them, using a silent mention of the acting user. The message follows this format: "@_**username** unsubscribed you from the channel #channel_name." Fixes: zulip#29272 Co-authored-by: Tanmay Kumar <tnmkr@users.noreply.github.com>
Aditya8840
force-pushed
the
unsubscribe
branch
from
6e060c2 to
3b5ea61
Compare
|
@prakhar1144 I have rebased this PR. Could you please take a look and provide some initial feedback? |
|
Heads up @Aditya8840, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Notification Bot only sent messages to notify users when they were added to channels by others. However, there was no corresponding notification when they were removed from channels.
This commit ensures that when a user is unsubscribed from a channel by another user, Notification Bot sends a message to inform them, using a silent mention of the acting user. The message follows this format:
Fixes: #29272
Screenshots and Screen Captures
Self-review Checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: