Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Show titles of GitHub issues on hover fixes: #19710 #31507

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Feat: Show titles of GitHub issues on hover fixes: #19710 #31507

wants to merge 1 commit into from

Conversation

brijsiyag
Copy link
Member

Fixes: #19710

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

zulipbot commented Sep 1, 2024

Hello @brijsiyag, it seems like you have referenced #19710 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #19710..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@brijsiyag
Copy link
Member Author

brijsiyag commented Sep 1, 2024 •
edited
Loading

@zulipbot add "rust community request"

@zulipbot zulipbot added the area: message feed (display) Web frontend rendering of messages (post markdown) label Sep 1, 2024
@brijsiyag
Copy link
Member Author

@zulipbot add "rust community request"

@zulipbot zulipbot added the rust community request Issues of interest to the Rust community label Sep 1, 2024
@zulipbot
Copy link
Member

Heads up @brijsiyag, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: message feed (display) Web frontend rendering of messages (post markdown) has conflicts rust community request Issues of interest to the Rust community size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show titles of GitHub issues on hover
3 participants
@brijsiyag @zulipbot @brijsiyag-meesho