message_view: Update autoscroll on message sent. #29387
Conversation
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Fixes zulip#23298.
zulipbot
added
size: XL
area: message feed (scrolling)
|
Hello @zulip/design members, this pull request was labeled with the "UI experiment" label, so you may want to check it out! |
|
Hm, I'm seeing something weird happening with the scroll down button.
The message ends up being tight to the compose box, and the button for scrolling down is shown. The button sticks around unexpectedly when you scroll down.
|
|
I think it would look better to scroll down a bit further, leaving some blank space above the compose box. I dunno if that will help with the scroll button issue as well. |
|
I'm excited to see progress on this one! |
|
@alya This PR is just a rebased version of #23298 which now on closer inspection I realize was never really approved (there were other PRs based off it, so I'd wrongly assumed that it worked as expected, and was just out of date), and some of the complex code changes there do not make sense to me... So I worked on a less complex fix from scratch myself, #29398. It resolves the issues you faced on testing this. If you think #29398 works better, I'll close this in its favour. Please check it out! |
|
Closed in favour of #29398 |
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view.
Fixes #23298.
(Updated, rebased on main version of original PR #23539 by @JoeyPriceless)