Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org_settings: Using the file name as the emoji_name #20458

Closed
wants to merge 1 commit into from
Closed

org_settings: Using the file name as the emoji_name #20458

wants to merge 1 commit into from

Conversation

somesh202
Copy link
Collaborator

Fixes part of #20316
Testing plan:

GIFs or screenshots:

@timabbott
Copy link
Member

@somesh202 thanks for working on this! I don't think we want to use the emoji filename when submitting; instead, the idea was to prepopulate the name field if empty when uploading the emoji file.

@somesh202
Copy link
Collaborator Author

@timabbott In this case, if the name field is empty and user submits the emoji, then it uses the filename as the emoji name.
Can you please elaborate on the idea of pre-populating the field once, so that I can implement that?
Thanks!

@timabbott
Copy link
Member

The intent is for the user to see what name might be used before a request is sent to the server to create that emoji; it's not a good user experience to auto-submit a value, since the user won't have the opportunity to view and potentially change it if they don't want to use the filename.

@somesh202
Copy link
Collaborator Author

Screenshot 2021-12-12 100213

This is a sample data list that would suggest the user for selecting names and can also write/modify it before submitting the emoji. Will this work? @timabbott

@gnprice gnprice added the area: emoji Emoji in markup, emoji reactions, emoji picker, etc. label Sep 29, 2023
@zulipbot
Copy link
Member

Hello @zulip/server-emoji members, this pull request was labeled with the "area: emoji" label, so you may want to check it out!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: emoji Emoji in markup, emoji reactions, emoji picker, etc. size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants