Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quote-and-reply: Quote part of a message #19735

Closed
wants to merge 1 commit into from
Closed

quote-and-reply: Quote part of a message #19735

wants to merge 1 commit into from

Conversation

jonnyktran
Copy link
Collaborator

@jonnyktran jonnyktran commented Sep 13, 2021 •
edited
Loading

Fixes #19712, Fixes #8951
Continues the work of PR #18850 and PR #15235

Testing plan:
Manual testing.

GIFs or screenshots:

Quote and reply using the > hotkey.
quote_hotkey

Quote and reply using the menu option.
quote_menu

Summary

  • When nothing is highlighted, fully quote the currently selected message
  • When part of a message is highlighted, quote only the highlighted text
  • If the user highlights multiple messages, same behavior as nothing highlighted
  • The quote-and-reply menu option has the same behavior as the > hotkey

Issues

  • Formatting is not preserved when quoting only part of a message

@zulipbot zulipbot added size: M and removed size: L labels Sep 13, 2021
@zulipbot zulipbot added size: L and removed size: M labels Sep 13, 2021
@jonnyktran jonnyktran force-pushed the quote-selected branch 2 times, most recently from 67dc106 to cc27258 Compare September 13, 2021 08:07
@camelid
Copy link
Contributor

camelid commented Sep 13, 2021

Text will not be italicized, bolded, etc. when quoting only part of a message

Does this mean that formatting will be lost when quoting part of a message? I would expect quoting part of a message to behave the same as quoting the whole message and deleting the irrelevant parts. Or did I misunderstand?

@zulipbot
Copy link
Member

Hello @jonathanktran, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@jonnyktran
Copy link
Collaborator Author

@camelid

I would expect quoting part of a message to behave the same as quoting the whole message and deleting the irrelevant parts.

This is the desired behavior, but I am currently not sure how to implement that. I have updated my pull request to clarify that this is an issue. Any suggestions would be greatly appreciated!

@jonnyktran
quote-and-reply: Quote part of a message
db1ffcf 
Summary
- When nothing is highlighted, fully quote the currently selected message
- When part of a message is highlighted, quote only the highlighted text
- If the user highlights multiple messages, same behavior as nothing highlighted
- The quote-and-reply menu option has the same behavior as the > hotkey

Issues
- Formatting is not preserved when quoting only part of a message

Fixes zulip#19712, Fixes zulip#8951
@jonnyktran jonnyktran changed the title Quote part of a message quote-and-reply: Quote part of a message Sep 14, 2021
@zulipbot
Copy link
Member

Heads up @jonathanktran, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@timabbott
Copy link
Member

@jonathanktran do you have a few minutes to rebase this? I'd like to test it out and see if we can integrate it for 5.0.

@timabbott timabbott added the release goal We'd like to resolve this for the current major release label Feb 1, 2022
@timabbott timabbott added post release Issues to focus attention on after the current major release and removed release goal We'd like to resolve this for the current major release labels Mar 18, 2022
@timabbott timabbott force-pushed the main branch 2 times, most recently from 4ec3636 to 88b200c Compare August 18, 2023 23:52
@timabbott timabbott added area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) area: compose (formatting) Compose box formatting UI (keyboard and mouse) and removed area: compose (misc) labels Sep 19, 2023
@timabbott
Copy link
Member

Closing in favor of #21834 for this issue.

@timabbott timabbott closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: compose (formatting) Compose box formatting UI (keyboard and mouse) area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) has conflicts post release Issues to focus attention on after the current major release size: L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Highlight Text and type 'r' to Have Text Auto-Quoted in Reply Quote part of a message
4 participants
@jonnyktran @camelid @zulipbot @timabbott