Notify message sender about emoji reactions #27327
Comments
alya
added
help wanted
feedback wanted
area: notifications (other)
new feature
|
@zulipbot claim |
|
Hello @TsionZerihun, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again. We look forward to your valuable contributions! |
|
@zulipbot claim |
|
Hello @Rahulr2101, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again. We look forward to your valuable contributions! |
|
@zulipbot claim |
|
Hello @Rahulr2101, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again. We look forward to your valuable contributions! |
|
@zulipbot claim |
|
Welcome to Zulip, @Nancyenos! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@Nancyenos You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
|
@zulipbot claim |
|
Welcome to Zulip, @DmitrySkibitsky! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
@alya I'm currently working on implementing the reaction notification feature, and I have a couple of clarifying questions to ensure we align on the intended behavior and user experience: Question 1: Could you please confirm whether the expectation is to update the unread count in the app alongside sending a notification for reactions? Question 2: Regarding reactions sent in a topic, should notifications be sent to everyone in the topic, or just the person whose message received the reaction? Additionally, I've put together a short video showcasing the initial implementation of the feature. Issue-27327.mov |
No, we are not marking the message as unread.
As the issue says, just the sender. |
|
@akarsh-jain-790 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
|
@zulipbot claim |
|
unassigning myself since the draft PR seems to be nearly completed. |
|
@akarsh-jain-790 are you still working on it? |
Yes,the initial implementation is ready for review was just waiting for the feedback |
|
Looks like the PR (#27910) now needs to have tests fixes and a rebase, to be ready for review. @akarsh-jain-790 do you plan to take this up? |
Yes, I plan to take this up. I'll work on the test fixes and rebase it soon. |
@alya I have fixed the test and PR is ready for review! |
As reported in #3285, it can be helpful for the sender of a message to be notified about emoji reactions. We should add notification settings for reactions to the messages you sent.
Setting for whether to notify about reactions
Settings for notification types
When an option other than "Never" is selected for the setting above, we should add a "Reactions to my messages" line to the notification settings table. This should let the use configure which types of notifications to receive. We can put it just below "Followed topics".
Notes:
initial CZO thread
design thread
The text was updated successfully, but these errors were encountered: