sentry: Improve logging for events mysteriously targeting text nodes.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
zulip · Apr 11, 2024 · 96be3a5 · 96be3a5
1 parent b6473de
commit 96be3a5
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -160,7 +160,8 @@
     },
     "patchedDependencies": {
       "source-sans@3.46.0": "patches/source-sans@3.46.0.patch",
-      "eslint-plugin-no-jquery@2.7.0": "patches/eslint-plugin-no-jquery@2.7.0.patch"
+      "eslint-plugin-no-jquery@2.7.0": "patches/eslint-plugin-no-jquery@2.7.0.patch",
+      "@sentry/utils@7.109.0": "patches/@sentry__utils@7.109.0.patch"
     }
   },
   "nyc": {

diff --git a/patches/@sentry__utils@7.109.0.patch b/patches/@sentry__utils@7.109.0.patch
@@ -0,0 +1,14 @@
+diff --git a/esm/object.js b/esm/object.js
+index c63c1777dca0efb8b0e615da57dd9e8f2017ed32..bc57d870811e8af591f966a87b02f319d8bd13ac 100644
+--- a/esm/object.js
++++ b/esm/object.js
+@@ -133,6 +133,9 @@ function convertToPlainObject(
+ /** Creates a string representation of the target of an `Event` object */
+ function serializeEventTarget(target) {
+   try {
++    if (target instanceof Text) {
++      return htmlTreeAsString(target.parentElement) + " > ::text";
++    }
+     return isElement(target) ? htmlTreeAsString(target) : Object.prototype.toString.call(target);
+   } catch (_oO) {
+     return '<unknown>';
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml