Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable connecting external RSS during unit testing #626

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Disable connecting external RSS during unit testing #626

merged 4 commits into from
Jan 15, 2025

Conversation

pboguslawski
Copy link
Contributor

Proposed change

In 6370b5b connecting external RSS was disabled only in Basic.t and according to #45 it should be disabled in PictureUpload.t also. This mod fixes it.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Fixes: 6370b5b
Related: #45
Author-Change-Id: IB#1156232

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@pboguslawski
Disable connecting external RSS during unit testing
aa72704 
In 6370b5b connecting externa RSS was
disabled only in `Basic.t` and according to znuny#45
it should be disabled in `PictureUpload.t` also. This mod fixes it.

Fixes: 6370b5b
Related: znuny#45
Author-Change-Id: IB#1156232
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@pboguslawski
Update CHANGES.md
f66300f
@pboguslawski
Update PictureUpload.t
3c7f3ac
@pboguslawski
Merge branch 'rel-6_5-dev' into rel-6_5-IB#1156232
510c22d
dennykorsukewitz
dennykorsukewitz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pboguslawski ,
thanks for your PR.

Approved 👍

Regards 🚀

@dennykorsukewitz dennykorsukewitz added the 3 - wait for reviewer Znuny, it's your turn. label Jan 10, 2025
@rkaldung rkaldung added 4 - verified This issue or pull request was verified. and removed 3 - wait for reviewer Znuny, it's your turn. labels Jan 11, 2025
@dennykorsukewitz dennykorsukewitz self-assigned this Jan 14, 2025
@dennykorsukewitz dennykorsukewitz added the 3 - wait for merge Znuny, it's your turn. label Jan 14, 2025
@dennykorsukewitz dennykorsukewitz merged commit 892e675 into znuny:rel-6_5-dev Jan 15, 2025
13 of 14 checks passed
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennykorsukewitz dennykorsukewitz dennykorsukewitz approved these changes

@rkaldung rkaldung rkaldung approved these changes

Assignees

@dennykorsukewitz dennykorsukewitz

Labels
4 - verified This issue or pull request was verified.
Milestone
rel-6_5_12
Development

Successfully merging this pull request may close these issues.
3 participants
@pboguslawski @rkaldung @dennykorsukewitz