Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(eventstore): faster push on crdb #9183

Closed
wants to merge 4 commits into from

Conversation

adlerhurst
Copy link
Member

Which Problems Are Solved

Replace this example text with a concise list of problems that this PR solves.
For example:)

  • If the property XY is not given, the system crashes with a nil pointer exception.

How the Problems Are Solved

Replace this example text with a concise list of changes that this PR introduces.
For example:

  • Validates if property XY is given and throws an error if not

Additional Changes

Replace this example text with a concise list of additional changes that this PR introduces, that are not directly solving the initial problem but are related.
For example:

  • The docs explicitly describe that the property XY is mandatory
  • Adds missing translations for validations.

Additional Context

Replace this example with links to related issues, discussions, discord threads, or other sources with more context.
Use the Closing #issue syntax for issues that are resolved with this PR.

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 10:06am

Copy link

Thanks for your contribution @adlerhurst! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

@adlerhurst adlerhurst changed the base branch from main to feat-permission-table January 15, 2025 07:49
@adlerhurst adlerhurst marked this pull request as draft January 15, 2025 07:49
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.39%. Comparing base (69a38aa) to head (b289ef8).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat-permission-table    #9183       +/-   ##
==========================================================
+ Coverage                  11.14%   36.39%   +25.24%     
==========================================================
  Files                       1518     1517        -1     
  Lines                     145378   145046      -332     
==========================================================
+ Hits                       16208    52789    +36581     
+ Misses                    128296    88195    -40101     
- Partials                     874     4062     +3188     
Flag Coverage Δ
core-integration-tests-postgres 36.39% <ø> (+25.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adlerhurst
Copy link
Member Author

closed in favor of #9186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant