Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct usage of nbf in oidc id token #9173

Merged
merged 1 commit into from
Jan 14, 2025
Merged

docs: correct usage of nbf in oidc id token #9173

merged 1 commit into from
Jan 14, 2025

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Jan 13, 2025

Which Problems Are Solved

Wrongly not returned but documented 'nbf' claim in ID token.

How the Problems Are Solved

Correct documentation to not include 'nbf' in ID token.

Additional Changes

None

Additional Context

None

@stebenz stebenz requested a review from livio-a January 13, 2025 10:09
@stebenz stebenz self-assigned this Jan 13, 2025
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 10:19am

Copy link

Thanks for your contribution @stebenz! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.40%. Comparing base (9c7f2a7) to head (805de81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9173   +/-   ##
=======================================
  Coverage   62.40%   62.40%           
=======================================
  Files        1588     1588           
  Lines      148785   148785           
=======================================
+ Hits        92850    92852    +2     
+ Misses      51367    51365    -2     
  Partials     4568     4568           
Flag Coverage Δ
core-integration-tests-postgres 36.32% <ø> (+<0.01%) ⬆️
core-unit-tests 46.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a merged commit e2a2e13 into main Jan 14, 2025
27 checks passed
@livio-a livio-a deleted the docs-nbf branch January 14, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants