-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(/internal): Add User Resource Owner #9168
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the unit tests for the queries in iam_member_test.go
, org_member_test.go
, project_member_test.go
and project_grant_member_test.go
.
Have a look at the makefile under 'core_integration_test'.
With that the PR looks good, and should be able to merge.
Thank you for the effort.
Okay , I will change the unit tests |
I think , i made a mistake the commits were not signed with verified status . Will the changes still get's merged? |
Unfortunate, but it should still be possible to merge. |
The core_integration_test is failing which i have not changed |
Owner Update the ../proto/zitadel/member.proto to include the UserResourceOwner as part of member. Update the queries to include UserResourceOwner for the following : zitadel/internal/query/iam_member.go zitadel/internal/query/org_member.go zitadel/internal/query/project_member.go zitadel/internal/query/project_grant_member.go Non Breaking Changes
de09fe1
to
b5b2a3b
Compare
@stebenz Updated the PR with signed commits, |
--- FAIL: TestServer_QuotaNotification_Limit (79.13s) |
No worries, has nothing to do with your changes. |
Update the ../proto/zitadel/member.proto to
include the UserResourceOwner as part of member.
Update the queries to include UserResourceOwner
for the following :
zitadel/internal/query/iam_member.go
zitadel/internal/query/org_member.go
zitadel/internal/query/project_member.go
zitadel/internal/query/project_grant_member.go
Non Breaking Changes
Which Problems Are Solved
#5062
How the Problems Are Solved
make compile
command .Additional Changes
Replace this example text with a concise list of additional changes that this PR introduces, that are not directly solving the initial problem but are related.
For example:
Additional Context