Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for weaviate vector store #474

Closed

Conversation

sunilkumardash9
Copy link

Added support for the Weaviate vector store #340

@sre-ci-robot sre-ci-robot requested review from cxie and xiaofan-luan July 7, 2023 11:22
@sre-ci-robot
Copy link
Collaborator

Welcome @sunilkumardash9! It looks like this is your first PR to zilliztech/GPTCache 🎉

@SimFG
Copy link
Collaborator

SimFG commented Jul 7, 2023

@sunilkumardash9 thank your contribution. please use the dev as the target branch

@SimFG SimFG changed the base branch from main to dev July 7, 2023 11:28
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunilkumardash9
To complete the pull request process, please assign cxie after the PR has been reviewed.
You can assign the PR to them by writing /assign @cxie in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

parthvnp and others added 7 commits July 7, 2023 17:23
* Add Qdrant vector store client

* Add setup for Qdrant vector store

* Add lazy import for Qdrant client library

* Add import_qdrant to index file

* Use models not types for building configs

* Add tests for Qdrant vector store

Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
* [add] support for mongodb store

* [add] unit test for mongodb store

* [mod] using [] instead of list, oid instead of _id, change unit tests

Signed-off-by: Anurag <a9raag@gmail.com>

* [add] Docker image for mongo, optimized imports

Signed-off-by: Anurag <a9raag@gmail.com>

* [refactor] disable warnings for `wrong-import-position`

Signed-off-by: Anurag <a9raag@gmail.com>

---------

Signed-off-by: Anurag <a9raag@gmail.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
1. Placed import_weaviate() before importing its functions
2. changed parameter name from 'collection_name' to 'class_name'
3. Few cosmetic changes
@mergify mergify bot added needs-dco and removed dco-passed labels Jul 18, 2023
1. Removed a hard-coded class_name in delete method
2. Better type check
@sunilkumardash9
Copy link
Author

@SimFG I think we need to update the SQLite versions. Python 3.8 probably ships with an older version that isn't supported anymore in chroma.

@SimFG
Copy link
Collaborator

SimFG commented Jul 21, 2023

@sunilkumardash9 it will be fixed in #488 pr

@SimFG
Copy link
Collaborator

SimFG commented Jul 21, 2023

@sunilkumardash9 I have handled the error, pr: #492

use old chromadb
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #474 (3dc0c73) into dev (bd152a7) will decrease coverage by 0.14%.
The diff coverage is 85.29%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #474      +/-   ##
==========================================
- Coverage   94.07%   93.94%   -0.14%     
==========================================
  Files          93       94       +1     
  Lines        3817     3883      +66     
==========================================
+ Hits         3591     3648      +57     
- Misses        226      235       +9     
Impacted Files Coverage Δ
gptcache/manager/scalar_data/mongo.py 92.95% <0.00%> (ø)
gptcache/manager/vector_data/weaviate.py 82.00% <82.00%> (ø)
gptcache/manager/vector_data/manager.py 99.19% <100.00%> (+0.10%) ⬆️
gptcache/utils/__init__.py 89.34% <100.00%> (+0.17%) ⬆️

@SimFG
Copy link
Collaborator

SimFG commented Jul 22, 2023

@sunilkumardash9 i will merge the pr: #493, because the pr fully meet the entry requirements.
Do you have some ideas? If have, please tell me as soon as possible, it is expected that I will merge today.

@sunilkumardash9
Copy link
Author

@SimFG No sir, you are free to merge.

@SimFG
Copy link
Collaborator

SimFG commented Jul 22, 2023

@sunilkumardash9 thank for your contribution and attention

@SimFG
Copy link
Collaborator

SimFG commented Jul 25, 2023

@sunilkumardash9 i will close the pull request. And if you have more ideas, please feel free to open a new pull request

@SimFG SimFG closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants