-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for weaviate vector store #474
Support for weaviate vector store #474
Conversation
Welcome @sunilkumardash9! It looks like this is your first PR to zilliztech/GPTCache 🎉 |
@sunilkumardash9 thank your contribution. please use the dev as the target branch |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunilkumardash9 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add Qdrant vector store client * Add setup for Qdrant vector store * Add lazy import for Qdrant client library * Add import_qdrant to index file * Use models not types for building configs * Add tests for Qdrant vector store Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
* [add] support for mongodb store * [add] unit test for mongodb store * [mod] using [] instead of list, oid instead of _id, change unit tests Signed-off-by: Anurag <a9raag@gmail.com> * [add] Docker image for mongo, optimized imports Signed-off-by: Anurag <a9raag@gmail.com> * [refactor] disable warnings for `wrong-import-position` Signed-off-by: Anurag <a9raag@gmail.com> --------- Signed-off-by: Anurag <a9raag@gmail.com> Co-authored-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>
8460083
to
b6a1899
Compare
1. Placed import_weaviate() before importing its functions 2. changed parameter name from 'collection_name' to 'class_name' 3. Few cosmetic changes
1. Removed a hard-coded class_name in delete method 2. Better type check
@SimFG I think we need to update the SQLite versions. Python 3.8 probably ships with an older version that isn't supported anymore in chroma. |
@sunilkumardash9 it will be fixed in #488 pr |
@sunilkumardash9 I have handled the error, pr: #492 |
use old chromadb
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #474 +/- ##
==========================================
- Coverage 94.07% 93.94% -0.14%
==========================================
Files 93 94 +1
Lines 3817 3883 +66
==========================================
+ Hits 3591 3648 +57
- Misses 226 235 +9
|
@sunilkumardash9 i will merge the pr: #493, because the pr fully meet the entry requirements. |
@SimFG No sir, you are free to merge. |
@sunilkumardash9 thank for your contribution and attention |
@sunilkumardash9 i will close the pull request. And if you have more ideas, please feel free to open a new pull request |
Added support for the Weaviate vector store #340