Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: library name is wrong for redis_om, instead it should be redis-om. #540

Closed
KeshavSingh29 opened this issue Sep 20, 2023 · 0 comments

Comments

@KeshavSingh29
Copy link
Contributor

KeshavSingh29 commented Sep 20, 2023

Current Behavior

In utils init.py

def import_redis():
    _check_library("redis")
    _check_library("redis_om")

The library name is wrong for redis_om, instead it should be redis-om.
Refer: https://github.com/redis/redis-om-python

Which creates error when running gptcache dependent libraries:
2023-09-20T05:39:32.596024342Z stderr F gptcache.utils.error.PipInstallError: Ran into error installing redis_om.

Expected Behavior

Should install redis-om package

Steps To Reproduce

Just install and run the latest code.

Environment

No response

Anything else?

If its okay, i made a quick PR.

@KeshavSingh29 KeshavSingh29 changed the title [Bug]: [Bug]: library name is wrong for redis_om, instead it should be redis-om. Sep 20, 2023
@SimFG SimFG closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants