Fix incremental build of sonar web

zhuomingliang · Mar 14, 2018 · b7497de · b7497de
1 parent acabda0
commit b7497de
Show file tree

Hide file tree

Showing 39 changed files with 41 additions and 41 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,12 +1,3 @@
-# The following should be moved in related sub-directories
-server/sonar-web/src/main/webapp/stylesheets/sonar-colorizer.css
-server/sonar-web/src/main/webapp/deploy/plugins
-server/sonar-web/src/main/webapp/deploy/bootstrap
-server/sonar-web/src/main/webapp/deploy/maven/org
-server/sonar-web/src/main/webapp/WEB-INF/log/
-server/sonar-web/src/main/webapp/deploy/*.jar
-server/sonar-web/src/main/webapp/deploy/jdbc-driver.txt
-
 # ---- Gradle
 build/
 .gradle/

diff --git a/server/sonar-web/.gitignore b/server/sonar-web/.gitignore
@@ -16,13 +16,6 @@ yarn-error.log
 #webpack
 .awcache/
 
-# build
-build/
-src/main/webapp/js/
-src/main/webapp/css/
-src/main/webapp/index.html
-src/main/webapp/WEB-INF/lib/*.jar
-
 # tests
 src/test/json/**/*.png
 lcov.info

diff --git a/server/sonar-web/build.gradle b/server/sonar-web/build.gradle
@@ -9,21 +9,44 @@ sonarqube {
 }
 
 apply plugin: 'com.moowork.node'
-apply plugin: 'war'
 
 configurations {
   branding
 }
 dependencies {
   branding 'com.sonarsource:sonarsource-branding:1.3.0.307@war'
 }
+
+def webappDir = "${buildDir}/webapp"
+def brandingDir = "${buildDir}/branding"
+
 task unzipBranding(type: Copy) {
-  into projectDir
   from { zipTree(configurations.branding.singleFile) }
+  into brandingDir
+}
+task copyBrandingSrc(type: Copy, dependsOn: unzipBranding) {
+  into projectDir
+  from file(brandingDir)
   include '**/*.js'
+  includeEmptyDirs = false
+}
+task copyBrandingWebapp(type: Copy, dependsOn: unzipBranding) {
+  into "${projectDir}/public"
+  from file("${brandingDir}/src/main/webapp")
   include '**/*.svg'
   includeEmptyDirs = false
 }
+task copyBrandingFile(type: Copy, dependsOn: unzipBranding) {
+  into "${projectDir}/public"
+  from file(brandingDir)
+  include '**/branding'
+  includeEmptyDirs = false
+}
+task copyBranding() {
+  dependsOn copyBrandingSrc
+  dependsOn copyBrandingWebapp
+  dependsOn copyBrandingFile
+}
 
 node {
   version = '8.5.0'
@@ -32,13 +55,17 @@ node {
 }
 
 yarn_run {
-  if (release) { dependsOn unzipBranding }
+  if (release) { dependsOn copyBranding }
+  inputs.dir('config')
+  inputs.dir('public')
   inputs.dir('scripts')
-  inputs.dir('src/main/js')
+  inputs.dir('src')
+  inputs.file('.babelrc')
   inputs.file('build.gradle')
-  outputs.dir('src/main/webapp')
+  inputs.file('package.json')
+  inputs.file('tsconfig.json')
+  inputs.file('yarn.lock')
+  outputs.dir(webappDir)
 
   args = ['build']
 }
-
-war.dependsOn yarn_run
diff --git a/server/sonar-web/config/paths.js b/server/sonar-web/config/paths.js
@@ -45,14 +45,14 @@ const nodePaths = (process.env.NODE_PATH || '')
 
 // config after eject: we're in ./config/
 module.exports = {
-  appBuild: resolveApp('src/main/webapp'),
+  appBuild: resolveApp('build/webapp'),
   appPublic: resolveApp('public'),
   appHtml: resolveApp('public/index.html'),
   appPackageJson: resolveApp('package.json'),
   appSrc: resolveApp('src/main/js'),
-  jsBuild: resolveApp('src/main/webapp/js'),
-  cssBuild: resolveApp('src/main/webapp/css'),
-  htmlBuild: resolveApp('src/main/webapp/index.html'),
+  jsBuild: resolveApp('build/webapp/js'),
+  cssBuild: resolveApp('build/webapp/css'),
+  htmlBuild: resolveApp('build/webapp/index.html'),
   appNodeModules: resolveApp('node_modules'),
   ownNodeModules: resolveApp('node_modules'),
   nodePaths

diff --git a/server/sonar-web/src/main/webapp/.htaccess → server/sonar-web/public/.htaccess b/server/sonar-web/src/main/webapp/.htaccess → server/sonar-web/public/.htaccess
diff --git a/...sonar-web/src/main/webapp/WEB-INF/web.xml → server/sonar-web/public/WEB-INF/web.xml b/...sonar-web/src/main/webapp/WEB-INF/web.xml → server/sonar-web/public/WEB-INF/web.xml
diff --git a/.../main/webapp/apple-touch-icon-114x114.png → ...r-web/public/apple-touch-icon-114x114.png b/.../main/webapp/apple-touch-icon-114x114.png → ...r-web/public/apple-touch-icon-114x114.png
diff --git a/.../main/webapp/apple-touch-icon-120x120.png → ...r-web/public/apple-touch-icon-120x120.png b/.../main/webapp/apple-touch-icon-120x120.png → ...r-web/public/apple-touch-icon-120x120.png
diff --git a/.../main/webapp/apple-touch-icon-144x144.png → ...r-web/public/apple-touch-icon-144x144.png b/.../main/webapp/apple-touch-icon-144x144.png → ...r-web/public/apple-touch-icon-144x144.png
diff --git a/.../main/webapp/apple-touch-icon-152x152.png → ...r-web/public/apple-touch-icon-152x152.png b/.../main/webapp/apple-touch-icon-152x152.png → ...r-web/public/apple-touch-icon-152x152.png
diff --git a/.../main/webapp/apple-touch-icon-180x180.png → ...r-web/public/apple-touch-icon-180x180.png b/.../main/webapp/apple-touch-icon-180x180.png → ...r-web/public/apple-touch-icon-180x180.png
diff --git a/...rc/main/webapp/apple-touch-icon-57x57.png → ...nar-web/public/apple-touch-icon-57x57.png b/...rc/main/webapp/apple-touch-icon-57x57.png → ...nar-web/public/apple-touch-icon-57x57.png
diff --git a/...rc/main/webapp/apple-touch-icon-60x60.png → ...nar-web/public/apple-touch-icon-60x60.png b/...rc/main/webapp/apple-touch-icon-60x60.png → ...nar-web/public/apple-touch-icon-60x60.png
diff --git a/...rc/main/webapp/apple-touch-icon-72x72.png → ...nar-web/public/apple-touch-icon-72x72.png b/...rc/main/webapp/apple-touch-icon-72x72.png → ...nar-web/public/apple-touch-icon-72x72.png
diff --git a/...rc/main/webapp/apple-touch-icon-76x76.png → ...nar-web/public/apple-touch-icon-76x76.png b/...rc/main/webapp/apple-touch-icon-76x76.png → ...nar-web/public/apple-touch-icon-76x76.png
diff --git a/...n/webapp/apple-touch-icon-precomposed.png → ...b/public/apple-touch-icon-precomposed.png b/...n/webapp/apple-touch-icon-precomposed.png → ...b/public/apple-touch-icon-precomposed.png
diff --git a/...-web/src/main/webapp/apple-touch-icon.png → server/sonar-web/public/apple-touch-icon.png b/...-web/src/main/webapp/apple-touch-icon.png → server/sonar-web/public/apple-touch-icon.png
diff --git a/server/sonar-web/src/main/webapp/favicon.ico → server/sonar-web/public/favicon.ico b/server/sonar-web/src/main/webapp/favicon.ico → server/sonar-web/public/favicon.ico
diff --git a/...r-web/src/main/webapp/fonts/sonar-5.2.eot → server/sonar-web/public/fonts/sonar-5.2.eot b/...r-web/src/main/webapp/fonts/sonar-5.2.eot → server/sonar-web/public/fonts/sonar-5.2.eot
diff --git a/...r-web/src/main/webapp/fonts/sonar-5.2.svg → server/sonar-web/public/fonts/sonar-5.2.svg b/...r-web/src/main/webapp/fonts/sonar-5.2.svg → server/sonar-web/public/fonts/sonar-5.2.svg
diff --git a/...r-web/src/main/webapp/fonts/sonar-5.2.ttf → server/sonar-web/public/fonts/sonar-5.2.ttf b/...r-web/src/main/webapp/fonts/sonar-5.2.ttf → server/sonar-web/public/fonts/sonar-5.2.ttf
diff --git a/...-web/src/main/webapp/fonts/sonar-5.2.woff → server/sonar-web/public/fonts/sonar-5.2.woff b/...-web/src/main/webapp/fonts/sonar-5.2.woff → server/sonar-web/public/fonts/sonar-5.2.woff
diff --git a/...ar-web/src/main/webapp/images/loading.gif → server/sonar-web/public/images/loading.gif b/...ar-web/src/main/webapp/images/loading.gif → server/sonar-web/public/images/loading.gif
diff --git a/...sonar-web/src/main/webapp/images/logo.svg → server/sonar-web/public/images/logo.svg b/...sonar-web/src/main/webapp/images/logo.svg → server/sonar-web/public/images/logo.svg
diff --git a/...mages/project_badges/sonarcloud-black.svg → ...mages/project_badges/sonarcloud-black.svg b/...mages/project_badges/sonarcloud-black.svg → ...mages/project_badges/sonarcloud-black.svg
diff --git a/...ages/project_badges/sonarcloud-orange.svg → ...ages/project_badges/sonarcloud-orange.svg b/...ages/project_badges/sonarcloud-orange.svg → ...ages/project_badges/sonarcloud-orange.svg
diff --git a/...mages/project_badges/sonarcloud-white.svg → ...mages/project_badges/sonarcloud-white.svg b/...mages/project_badges/sonarcloud-white.svg → ...mages/project_badges/sonarcloud-white.svg
diff --git a/.../main/webapp/images/scanner-logos/ant.svg → ...r-web/public/images/scanner-logos/ant.svg b/.../main/webapp/images/scanner-logos/ant.svg → ...r-web/public/images/scanner-logos/ant.svg
diff --git a/...in/webapp/images/scanner-logos/gradle.svg → ...eb/public/images/scanner-logos/gradle.svg b/...in/webapp/images/scanner-logos/gradle.svg → ...eb/public/images/scanner-logos/gradle.svg
diff --git a/...n/webapp/images/scanner-logos/jenkins.svg → ...b/public/images/scanner-logos/jenkins.svg b/...n/webapp/images/scanner-logos/jenkins.svg → ...b/public/images/scanner-logos/jenkins.svg
diff --git a/...ain/webapp/images/scanner-logos/maven.svg → ...web/public/images/scanner-logos/maven.svg b/...ain/webapp/images/scanner-logos/maven.svg → ...web/public/images/scanner-logos/maven.svg
diff --git a/...n/webapp/images/scanner-logos/msbuild.svg → ...b/public/images/scanner-logos/msbuild.svg b/...n/webapp/images/scanner-logos/msbuild.svg → ...b/public/images/scanner-logos/msbuild.svg
diff --git a/...webapp/images/scanner-logos/sonarqube.svg → ...public/images/scanner-logos/sonarqube.svg b/...webapp/images/scanner-logos/sonarqube.svg → ...public/images/scanner-logos/sonarqube.svg
diff --git a/...ar-web/src/main/webapp/images/select2.png → server/sonar-web/public/images/select2.png b/...ar-web/src/main/webapp/images/select2.png → server/sonar-web/public/images/select2.png
diff --git a/...-web/src/main/webapp/images/select2x2.png → server/sonar-web/public/images/select2x2.png b/...-web/src/main/webapp/images/select2x2.png → server/sonar-web/public/images/select2x2.png
diff --git a/...ar-web/src/main/webapp/mstile-512x512.png → server/sonar-web/public/mstile-512x512.png b/...ar-web/src/main/webapp/mstile-512x512.png → server/sonar-web/public/mstile-512x512.png
diff --git a/server/sonar-web/src/main/webapp/robots.txt → server/sonar-web/public/robots.txt b/server/sonar-web/src/main/webapp/robots.txt → server/sonar-web/public/robots.txt
diff --git a/server/sonar-web/scripts/build.js b/server/sonar-web/scripts/build.js
@@ -37,14 +37,8 @@ function clean() {
   // if you're in it, you don't end up in Trash
   console.log(chalk.cyan.bold('Cleaning output directories and files...'));
 
-  console.log(paths.jsBuild + '/*');
-  rimrafSync(paths.jsBuild + '/*');
-
-  console.log(paths.cssBuild + '/*');
-  rimrafSync(paths.cssBuild + '/*');
-
-  console.log(paths.htmlBuild);
-  rimrafSync(paths.htmlBuild);
+  console.log(paths.appBuild + '/*');
+  rimrafSync(paths.appBuild + '/*');
 
   console.log();
 }

diff --git a/sonar-application/build.gradle b/sonar-application/build.gradle
@@ -9,7 +9,6 @@ configurations {
   jsw
   scanner
   server
-  webapp
   jdbc_mssql {
     transitive = false
   }
@@ -40,7 +39,6 @@ dependencies {
   jsw 'tanukisoft:wrapper:3.2.3'
   scanner project(path: ':sonar-scanner-engine-shaded', configuration: 'shadow')
   server project(':server:sonar-server')
-  webapp project(path: ':server:sonar-web', configuration: 'archives')
 
   jdbc_h2 'com.h2database:h2'
   jdbc_mssql 'com.microsoft.sqlserver:mssql-jdbc'
@@ -103,11 +101,8 @@ task zip(type: Zip) {
   into("${archiveDir}/lib/common/") {
     from configurations.ce + configurations.server + configurations.compile
   }
-  dependsOn configurations.webapp
   into("${archiveDir}/web/") {
-    from {
-      configurations.webapp.files.collect { zipTree(it) }
-    }
+    from tasks.getByPath(':server:sonar-web:yarn_run').outputs
   }
   into("${archiveDir}/lib/jdbc/mssql/") {
     from configurations.jdbc_mssql