Cover deliverer

zhulik · Feb 10, 2023 · 616ecaa · 616ecaa
1 parent 38d1fec
commit 616ecaa
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 4 deletions.
diff --git a/lib/nats_streamer/deliverer.rb b/lib/nats_streamer/deliverer.rb
@@ -6,14 +6,10 @@ class NatsStreamer::Deliverer
   include NatsStreamer::Logger
   include Memery
 
-  # TODO: how to propely unsubscribe?
   option :subscriber
 
   def deliver(**)
     info_measure(-> { connection.post(".", **) }) { "Event delivered to #{subscriber.name}: #{_1.round(2)}s" }
-  rescue StandardError => e
-    warn { "Event failed to be delivered to #{subscriber.name}" }
-    warn { e }
   end
 
   memoize def connection = NatsStreamer::Connection.build(subscriber.url)

diff --git a/spec/nats_streamer/deliverer_spec.rb b/spec/nats_streamer/deliverer_spec.rb
@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+RSpec.describe NatsStreamer::Deliverer do
+  let(:deliverer) { described_class.new(subscriber:) }
+  let(:subscriber) { instance_double(NatsStreamer::Config::Subscriber, url: "https://example.com", name: "test") }
+
+  describe "#deliver" do
+    subject { deliverer.deliver(test: "value") }
+
+    context "when delivered successfully" do
+      let!(:stub) do
+        stub_request(:post, "https://example.com/")
+          .with(body: { test: "value" })
+          .to_return(status: 200)
+      end
+
+      it "calls url" do
+        subject
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context "when delivery errored" do
+      let!(:stub) do
+        stub_request(:post, "https://example.com/")
+          .with(body: { test: "value" })
+          .to_return(status: 500)
+      end
+
+      it "raises Faraday::ServerError" do # rubocop:disable RSpec/MultipleExpectations
+        expect { subject }.to raise_error(Faraday::ServerError)
+        expect(stub).to have_been_requested
+      end
+    end
+  end
+end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+ENV["CONSOLE_LEVEL"] ||= "fatal"
+require "webmock/rspec"
 require "simplecov"
 
 SimpleCov.start