Merge pull request #550 from asmaloney/fix-weak-vtable-warning

Fix weak vtable warning regarding xml_writer
zeux · Apr 21, 2023 · 8d18de8 · 8d18de8
2 parents f4b8946 + 058fc60
commit 8d18de8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/pugixml.cpp b/src/pugixml.cpp
@@ -5111,6 +5111,10 @@ PUGI_IMPL_NS_END
 
 namespace pugi
 {
+	PUGI_IMPL_FN xml_writer::~xml_writer()
+	{
+	}
+
 	PUGI_IMPL_FN xml_writer_file::xml_writer_file(void* file_): file(file_)
 	{
 	}

diff --git a/src/pugixml.hpp b/src/pugixml.hpp
@@ -324,7 +324,7 @@ namespace pugi
 	class PUGIXML_CLASS xml_writer
 	{
 	public:
-		virtual ~xml_writer() {}
+		virtual ~xml_writer();
 
 		// Write memory chunk into stream/file/whatever
 		virtual void write(const void* data, size_t size) = 0;
-Original file line number
+Diff line change
@@ Expand Up / @@ -5111,6 +5111,10 @@ PUGI_IMPL_NS_END @@
     namespace pugi
     {
+    	PUGI_IMPL_FN xml_writer::~xml_writer()
+    	{
+    	}
     	PUGI_IMPL_FN xml_writer_file::xml_writer_file(void* file_): file(file_)
     	{
     	}
@@ Expand Down @@