Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Debugfn and Infofn to logx/logc #4595 #4598

Merged
merged 2 commits into from
Jan 25, 2025
Merged

add Debugfn and Infofn to logx/logc #4595 #4598

merged 2 commits into from
Jan 25, 2025

Conversation

studyzy
Copy link
Contributor

@studyzy studyzy commented Jan 23, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.49%. Comparing base (8690859) to head (6ebec7e).
Report is 234 commits behind head on master.

Files with missing lines Patch % Lines
core/logx/richlogger.go 0.00% 8 Missing ⚠️
core/logc/logs.go 0.00% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
core/logx/logs.go 99.05% <100.00%> (+0.13%) ⬆️
core/logc/logs.go 92.59% <0.00%> (-7.41%) ⬇️
core/logx/richlogger.go 94.93% <0.00%> (-5.07%) ⬇️

... and 9 files with indirect coverage changes

kevwan
kevwan approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge and write more unit tests.

@kevwan kevwan merged commit 64e8c94 into zeromicro:master Jan 25, 2025
5 of 6 checks passed
@kevwan kevwan mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@studyzy @kevwan