Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title property should be optional #40

Open
brachkow opened this issue Feb 6, 2023 · 2 comments
Open

Title property should be optional #40

brachkow opened this issue Feb 6, 2023 · 2 comments

Comments

@brachkow
Copy link

brachkow commented Feb 6, 2023

iframes (and some other blocks) have no title property

'2dd41fb9-8294-4d68-bf76-a4cddc789763': {
   role: 'reader',
   value: {
     id: '2dd41fb9-8294-4d68-bf76-a4cddc789763',
     version: 3,
     type: 'video',
     properties: {
       source: [['https://www.youtube.com/watch?v=jNQXAC9IVRw']],
     },

but it is not optional

vue3-notion/src/lib/types.ts

Line 57 in 1e6b447

title: string[]

@brachkow
Copy link
Author

brachkow commented Feb 6, 2023

value.content should be optional too — it exists only for a title of page, and page as block

@brachkow
Copy link
Author

brachkow commented Feb 6, 2023 •
edited
Loading

btw all type definitions are not working — see my previous issue #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brachkow