Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pipeline can't finish succesfully in this case #2903

Merged
merged 6 commits into from
Aug 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document raised error ins docstring
AlexejPenner committed Aug 7, 2024
commit e2cc179b239689145214f261e02a85aa9b02ac7c
Original file line number Diff line number Diff line change
@@ -574,6 +574,9 @@ def _upload_and_run_pipeline(
run_name: Orchestrator run name.
settings: Pipeline level settings for this orchestrator.
schedule: The schedule the pipeline will run on.

Raises:
RuntimeError: If the Vertex Orchestrator fails to provision or any other Runtime errors
"""
# We have to replace the hyphens in the run name with underscores
# and lower case the string, because the Vertex AI Pipelines service
2 changes: 1 addition & 1 deletion src/zenml/logger.py
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ def format(self, record: logging.LogRecord) -> str:
)

# Format URLs
url_pattern = r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\\(\\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+'
url_pattern = r"http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\\(\\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+"
urls = re.findall(url_pattern, formatted_message)
for url in urls:
formatted_message = formatted_message.replace(