Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Build passing with Failing tests #3596

Closed
Slamdunk opened this issue Jan 29, 2013 · 8 comments
Closed

Build passing with Failing tests #3596

Slamdunk opened this issue Jan 29, 2013 · 8 comments

Comments

@Slamdunk
Copy link
Contributor

Hi, some of the latest builds are passing, but with failing tests:

Imho this is a big issue; I invite not to fix the tests until the build are passing.

As of yet, I was unable to figure out why this happens.

@weierophinney
Copy link
Member

In talking to @ezimuel it appears that some test cases did not get merged properly to develop; he's going to get those fixed today.

@Slamdunk
Copy link
Contributor Author

Thank you for the fast answer. Just to be sure, I want to underline that I opened this issue not for the failing tests, but for the build passing, that is a bug much bigger than failing tests.

@weierophinney
Copy link
Member

@Slamdunk - right -- but the build failing shows us the fact that the tests were merge improperly -- it's a symptom of the underlying problem, basically.

@weierophinney
Copy link
Member

Nm, now I understand -- it looks like only the exit code of the last item in the script is being used to determine build success/failure -- this is an issue with travis.

Unfortunately not sure which specific travis project to submit an issue against!

@roidrage
Copy link

You can file an issue on https://github.com/travis-ci/travis-build.

@Slamdunk
Copy link
Contributor Author

In the meanwhile, pay attention to check all the build logs before a release :|

@ezimuel
Copy link
Contributor

ezimuel commented Jan 29, 2013

The PR #3600 fixes the unit tests for Zend\Filter\File\Encrypt and Decrypt. These 2 files have not been merged properly from master. In master the unit test works fine.

@ezimuel ezimuel closed this as completed Jan 29, 2013
@weierophinney
Copy link
Member

@Slamdunk Since the test failures point to what @ezimuel has fixed, it makes sense to fix this issue. We can track the issue against travis to ensure the root problem -- no reporting of tests failures -- is ultimately corrected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants