-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Build passing with Failing tests #3596
Comments
In talking to @ezimuel it appears that some test cases did not get merged properly to develop; he's going to get those fixed today. |
Thank you for the fast answer. Just to be sure, I want to underline that I opened this issue not for the failing tests, but for the build passing, that is a bug much bigger than failing tests. |
@Slamdunk - right -- but the build failing shows us the fact that the tests were merge improperly -- it's a symptom of the underlying problem, basically. |
Nm, now I understand -- it looks like only the exit code of the last item in the script is being used to determine build success/failure -- this is an issue with travis. Unfortunately not sure which specific travis project to submit an issue against! |
You can file an issue on https://github.com/travis-ci/travis-build. |
In the meanwhile, pay attention to check all the build logs before a release :| |
The PR #3600 fixes the unit tests for Zend\Filter\File\Encrypt and Decrypt. These 2 files have not been merged properly from master. In master the unit test works fine. |
Hi, some of the latest builds are passing, but with failing tests:
Imho this is a big issue; I invite not to fix the tests until the build are passing.
As of yet, I was unable to figure out why this happens.
The text was updated successfully, but these errors were encountered: