Zend\Log: ZF2-453 test for xml extra array prossing bug

zendframework · Aug 16, 2012 · 17b56b8 · 17b56b8
1 parent c08e950
commit 17b56b8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Formatter/Xml.php b/src/Formatter/Xml.php
@@ -153,7 +153,7 @@ public function format($event)
             ) {
                 if ($key == "message") {
                     $value = htmlspecialchars($value, ENT_COMPAT, $enc);
-                } elseif($key == "extra" && empty($value)) {
+                } elseif ($key == "extra" && empty($value)) {
                     continue;
                 }
                 $elt->appendChild(new DOMElement($key, (string)$value));

diff --git a/test/Formatter/XmlTest.php b/test/Formatter/XmlTest.php
@@ -178,4 +178,23 @@ public function testObjectsWithStringSerializationAreIncludedInFormattedString()
         $output = $formatter->format($event);
         $this->assertContains($expected, $output);
     }
+
+    /**
+     * @group ZF2-453
+     */
+    public function testFormatWillRemoveExtraEmptyArrayFromEvent()
+    {
+        $formatter = new XmlFormatter;
+        $d = new DateTime('2001-01-01T12:00:00-06:00');
+        $event = array(
+            'timestamp'    =>  $d,
+            'message'      => 'test',
+            'priority'     => 1,
+            'priorityName' => 'CRIT',
+            'extra' => array()
+        );
+        $expected = '<logEntry><timestamp>2001-01-01T12:00:00-06:00</timestamp><message>test</message><priority>1</priority><priorityName>CRIT</priorityName></logEntry>';
+        $expected .= PHP_EOL . PHP_EOL;
+        $this->assertEquals($expected, $formatter->format($event));
+    }
 }